Source/modules/webaudio/AudioContext.cpp - Issue 691143007: Implement StereoPannerNode for robust stereo panning

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/webaudio/AudioContext.cpp

Issue 691143007: Implement StereoPannerNode for robust stereo panning (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/webaudio/stereopannernode-panning.html ('K') | « Source/modules/webaudio/AudioContext.h ('k') | Source/modules/webaudio/AudioContext.idl » ('j') | Source/modules/webaudio/StereoPannerNode.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/webaudio/AudioContext.cpp

diff --git a/Source/modules/webaudio/AudioContext.cpp b/Source/modules/webaudio/AudioContext.cpp

index e8b2c9cb721f98a30f28d4469e7b128eee224a4f..9902321526666f040d34d9b883d5d33f5b5c7aae 100644

--- a/Source/modules/webaudio/AudioContext.cpp

+++ b/Source/modules/webaudio/AudioContext.cpp

@@ -60,6 +60,7 @@

#include "modules/webaudio/PannerNode.h"

#include "modules/webaudio/PeriodicWave.h"

#include "modules/webaudio/ScriptProcessorNode.h"

+#include "modules/webaudio/StereoPannerNode.h"

#include "modules/webaudio/WaveShaperNode.h"

#include "platform/audio/FFTFrame.h"

#include "platform/audio/HRTFPanner.h"

@@ -365,6 +366,11 @@ ScriptProcessorNode* AudioContext::createScriptProcessor(size_t bufferSize, size

return node;

}

+StereoPannerNode* AudioContext::createStereoPanner()

Raymond Toy 2014/11/11 19:41:47 Add ASSERT(isMainThread()), like for other creator

hongchan 2014/11/12 00:06:53 Done.

+ return StereoPannerNode::create(this, m_destinationNode->sampleRate());

BiquadFilterNode* AudioContext::createBiquadFilter()

{

ASSERT(isMainThread());