Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: LayoutTests/webaudio/stereopannernode-panning.html

Issue 691143007: Implement StereoPannerNode for robust stereo panning (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« LayoutTests/webaudio/stereopannernode-basic.html ('K') | « LayoutTests/webaudio/stereopannernode-basic-expected.txt ('k') | LayoutTests/webaudio/stereopannernode-panning-expected.txt » ('j') | Source/modules/webaudio/AudioContext.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: LayoutTests/webaudio/stereopannernode-panning.html
diff --git a/LayoutTests/webaudio/stereopannernode-panning.html b/LayoutTests/webaudio/stereopannernode-panning.html
new file mode 100644
index 0000000000000000000000000000000000000000..ec0f8fe17cda68c1f859d62cdf4fcc6e7d193f02
--- /dev/null
+++ b/LayoutTests/webaudio/stereopannernode-panning.html
@@ -0,0 +1,182 @@
+<!DOCTYPE html>
+<html>
+
+<head>
+ <script src="resources/compatibility.js"></script>
+ <script src="resources/audio-testing.js"></script>
+ <script src="../resources/js-test.js"></script>
+</head>
+
+<body>
+ <div id="description"></div>
+ <div id="console"></div>
+ <script>
+ description("Test panning model of StereoPannerNode.");
+
+ if (window.testRunner) {
+ testRunner.dumpAsText();
+ testRunner.waitUntilDone();
+ }
Raymond Toy 2014/11/11 19:41:46 Don't think the if is needed anymore.
hongchan 2014/11/12 00:06:53 Done.
+
+ window.jsTestIsAsync = true;
+
+ var sampleRate = 44100;
+
+ // Number of nodes to create for testing.
+ var nodesToCreate = 100;
+
+ // Interval between the onset of each impulse.
+ var timeStep = 0.001;
+
+ // Total render length. Should be long enough for all panner nodes.
+ var renderLength = timeStep * (nodesToCreate + 1);
+
+ var impulse,
+ impulseLength = Math.round(timeStep * sampleRate);
Raymond Toy 2014/11/11 19:41:46 This style is not generally allowed in blink or ch
hongchan 2014/11/12 00:06:53 I looked it up Google's JS style guide, but it doe
Raymond Toy 2014/11/12 00:16:44 Up to you. Chris always had me follow chromium (o
+
+ // Pan step unit for each test trial.
+ var panStep = 2 / (nodesToCreate - 1);
+
+ var sources = [],
+ panners = [],
+ panPositions = [],
+ onsets = [];
+
+ var ctx = new OfflineAudioContext(2, sampleRate * renderLength, sampleRate);
+
+ // Calculates channel gains based on equal power panning model.
+ function getChannelGains (pan) {
+ var normalized = 0.5 * Math.PI * (pan * 0.5 + 0.5);
+ return {
+ gainL: Math.cos(normalized),
+ gainR: Math.sin(normalized)
+ };
+ }
+
+ function prepareTest() {
+ impulse = createImpulseBuffer(ctx, impulseLength);
+
Raymond Toy 2014/11/11 19:41:46 Describe what you're connecting together here and
hongchan 2014/11/12 00:06:53 I will describe what I am doing here. But I think
Raymond Toy 2014/11/12 00:16:44 Acknowledged.
+ for (var i = 0; i < nodesToCreate; i++) {
+ sources[i] = ctx.createBufferSource();
+ panners[i] = ctx.createStereoPanner();
+ sources[i].connect(panners[i]);
+ panners[i].connect(ctx.destination);
+
+ sources[i].buffer = impulse;
+
+ // Moves the pan value for each panner by pan step unit.
+ panners[i].pan.value = panPositions[i] = panStep * i - 1;
+
+ onsets[i] = timeStep * i;
+ sources[i].start(onsets[i]);
+ }
+ }
+
+ function verifyResult(event) {
+
+ var success = true;
+
+ // The max error we allow between the rendered impulse and the
+ // expected value. This value is experimentally determined. Set
+ // to 0 to make the test fail to see what the actual error is.
+ var maxAllowedError = 1.3e-6;
+
+ var chanL = event.renderedBuffer.getChannelData(0),
+ chanR = event.renderedBuffer.getChannelData(1);
+
+ // Number of impulses found in the rendered result.
+ var impulseIndex = 0;
+
+ // Max (relative) error and the index of the maxima for the left
+ // and right channels.
+ var maxErrorL = 0,
+ maxErrorR = 0,
+ maxErrorIndexL = 0,
+ maxErrorIndexR = 0;
+
+ // Locations of where the impulses aren't at the expected locations.
+ var errors = [];
+
+ for (var i = 0; i < chanL.length; i++) {
+
+ // We assume that the left and right channels start at the same instant.
+ if (chanL[i] !== 0 || chanR[i] !== 0) {
+
+ // Get amount of error between actual and expected gain.
+ var expected = getChannelGains(panPositions[impulseIndex]),
+ errorL = Math.abs(chanL[i] - expected.gainL),
+ errorR = Math.abs(chanR[i] - expected.gainR);
+
+ if (errorL > maxErrorL) {
+ maxErrorL = errorL;
+ maxErrorIndexL = impulseIndex;
+ }
+
+ if (errorR > maxErrorR) {
+ maxErrorR = errorR;
+ maxErrorIndexR = impulseIndex;
+ }
+
+ // Keep track of the impulses that didn't show up where we expected
+ // them to be.
+ var expectedOffset = timeToSampleFrame(onsets[impulseIndex], sampleRate);
+ if (i != expectedOffset) {
+ errors.push({
+ actual: i,
+ expected: expectedOffset
+ });
+ }
+
+ impulseIndex++;
+ }
+ }
+
+ if (impulseIndex === nodesToCreate) {
+ testPassed('Number of impulses matches the number of panner nodes.');
+ } else {
+ testFailed('Number of impulses is incorrect. (Found ' + impulseIndex + ' but expected ' + nodesToCreate + ')');
+ sucess = false;
+ }
+
+ if (errors.length === 0) {
+ testPassed("All impulses at expected offsets.");
+ } else {
+ testFailed(errors.length + " timing errors found in " + nodesToCreate + " panner nodes.");
+ for (var i = 0; i < errors.length; i++) {
+ testFailed("Impulse at sample " + errors[i].actual + " but expected " + errors[i].expected);
+ }
+ success = false;
+ }
+
+ if (maxErrorL <= maxAllowedError) {
+ testPassed("Left channel gain values are correct.");
+ } else {
+ testFailed("Left channel gain values are incorrect. Max error = " + maxErrorL + " at time " + onsets[maxErrorIndexL] + " (threshold = " + maxAllowedError + ")");
+ success = false;
+ }
+
+ if (maxErrorR <= maxAllowedError) {
+ testPassed("Right channel gain values are correct.");
+ } else {
+ testFailed("Right channel gain values are incorrect. Max error = " + maxErrorR + " at time " + onsets[maxErrorIndexR] + " (threshold = " + maxAllowedError + ")");
+ success = false;
+ }
+
+ if (success) {
+ testPassed("EqualPower panner test passed");
+ } else {
+ testFailed("EqualPower panner test failed");
+ }
Raymond Toy 2014/11/11 19:41:46 Chromium and blink style does not use braces for s
hongchan 2014/11/12 00:06:53 I just copied this part from the previous panner t
Raymond Toy 2014/11/12 00:16:44 Actually, the blink style guide says this is ok in
+
+ finishJSTest();
+ }
+
+ prepareTest();
+ ctx.oncomplete = verifyResult;
+ ctx.startRendering();
+
+ successfullyParsed = true;
+ </script>
+</body>
+
+</html>
« LayoutTests/webaudio/stereopannernode-basic.html ('K') | « LayoutTests/webaudio/stereopannernode-basic-expected.txt ('k') | LayoutTests/webaudio/stereopannernode-panning-expected.txt » ('j') | Source/modules/webaudio/AudioContext.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698