Chromium Code Reviews Chromium Code Reviews
Issue 691143007:
Implement StereoPannerNode for robust stereo panning (Closed)
Base URL: https://chromium.googlesource.com/chromium/blink.git@master| Index: LayoutTests/webaudio/stereopannernode-basic.html |
| diff --git a/LayoutTests/webaudio/stereopannernode-basic.html b/LayoutTests/webaudio/stereopannernode-basic.html |
| new file mode 100644 |
| index 0000000000000000000000000000000000000000..a00a24c56810361a909f7b1ff8234e61344dc334 |
| --- /dev/null |
| +++ b/LayoutTests/webaudio/stereopannernode-basic.html |
| @@ -0,0 +1,43 @@ |
| +<!DOCTYPE html> |
| +<html> |
| + |
| +<head> |
| + <script src="resources/compatibility.js"></script> |
| + <script src="resources/audio-testing.js"></script> |
| + <script src="../resources/js-test.js"></script> |
| +</head> |
| + |
| +<body> |
| + <div id="description"></div> |
| + <div id="console"></div> |
| + <script> |
| + description("Test attribute and basic functionality of StereoPannerNode."); |
| + |
| + function runTest() { |
| + if (window.testRunner) { |
| + testRunner.dumpAsText(); |
| + testRunner.waitUntilDone(); |
| + } |
|
Raymond Toy
2014/11/11 19:41:46
I think the if statement is no longer needed.
hongchan
2014/11/12 00:06:53
Done.
Raymond Toy
2014/11/12 00:16:44
I think the style is to say "Done", after you uplo
|
| + |
| + window.jsTestIsAsync = true; |
| + |
| + context = new AudioContext(); |
| + var panner = context.createStereoPanner(); |
| + window.panner = panner; |
| + |
| + shouldBeTrue("panner.numberOfInputs === 1"); |
| + shouldBeTrue("panner.numberOfOutputs === 1"); |
| + shouldBeTrue("panner.pan.defaultValue === 0.0"); |
| + shouldBeTrue("panner.pan.value === 0.0"); |
| + panner.pan.value = 1.0; |
| + shouldBeTrue("panner.pan.value === 1.0"); |
| + |
|
Raymond Toy
2014/11/11 19:41:46
The spec says channelCount cannot be increased abo
hongchan
2014/11/12 00:06:53
For this CL, I have decided to fix the channelCoun
Raymond Toy
2014/11/12 00:16:44
Will the spec say the channelCount is fixed to 2?
|
| + finishJSTest(); |
| + } |
| + |
| + runTest(); |
| + successfullyParsed = true; |
| + </script> |
| +</body> |
| + |
| +</html> |
