Domain Reliability: Mark beacons from previous networks.

components/domain_reliability/context.h

Index: components/domain_reliability/context.h
diff --git a/components/domain_reliability/context.h b/components/domain_reliability/context.h
index 8082ca173f25a8411159cd3676daffa4bc0ddbba..a02a1fa36cf7c3eb06ca0c50d8c1200fdde66714 100644
--- a/components/domain_reliability/context.h
+++ b/components/domain_reliability/context.h
@@ -36,6 +36,7 @@ class DOMAIN_RELIABILITY_EXPORT DomainReliabilityContext {
       MockableTime* time,
       const DomainReliabilityScheduler::Params& scheduler_params,
       const std::string& upload_reporter_string,
+      const base::TimeTicks& last_network_change_time,
       DomainReliabilityDispatcher* dispatcher,
       DomainReliabilityUploader* uploader,
       scoped_ptr<const DomainReliabilityConfig> config);
@@ -110,6 +111,7 @@ class DOMAIN_RELIABILITY_EXPORT DomainReliabilityContext {
   ResourceStateVector states_;
   base::TimeTicks upload_time_;
   base::TimeTicks last_upload_time_;
+  const base::TimeTicks& last_network_change_time_;

[davidben, 2014/10/30 21:18:00]

It's really not obvious, certainly not from the constructor, that these guys are
all aliasing the parent's base::TimeTicks. (I thought at first there was no way
this code worked.) I don't think we use const references that way. Could it be
switched to a pointer and also documented? (Or perhaps it gets plumbed through
somewhere else?)

[Deprecated (see juliatuttle), 2014/10/31 22:01:02]

I'll make it a pointer.

 
   base::WeakPtrFactory<DomainReliabilityContext> weak_factory_;