Domain Reliability: Mark beacons from previous networks.

components/domain_reliability/context.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_DOMAIN_RELIABILITY_CONTEXT_H_
 #define COMPONENTS_DOMAIN_RELIABILITY_CONTEXT_H_
 
 #include <deque>
 #include <vector>
 
@@ skipping 18 matching lines @@
 class MockableTime;
 
 // The per-domain context for the Domain Reliability client; includes the
 // domain's config and per-resource beacon queues.
 class DOMAIN_RELIABILITY_EXPORT DomainReliabilityContext {
  public:
   DomainReliabilityContext(
       MockableTime* time,
       const DomainReliabilityScheduler::Params& scheduler_params,
       const std::string& upload_reporter_string,
+      const base::TimeTicks& last_network_change_time,
       DomainReliabilityDispatcher* dispatcher,
       DomainReliabilityUploader* uploader,
       scoped_ptr<const DomainReliabilityConfig> config);
   ~DomainReliabilityContext();
 
   // Notifies the context of a beacon on its domain(s); may or may not save the
   // actual beacon to be uploaded, depending on the sample rates in the config,
   // but will increment one of the request counters in any case.
   void OnBeacon(const GURL& url, const DomainReliabilityBeacon& beacon);
 
@@ skipping 54 matching lines @@
   DomainReliabilityDispatcher* dispatcher_;
   DomainReliabilityUploader* uploader_;
 
   BeaconDeque beacons_;
   size_t uploading_beacons_size_;
   // Each ResourceState in |states_| corresponds to the Resource of the same
   // index in the config.
   ResourceStateVector states_;
   base::TimeTicks upload_time_;
   base::TimeTicks last_upload_time_;
+  const base::TimeTicks& last_network_change_time_;

[davidben, 2014/10/30 21:18:00]

It's really not obvious, certainly not from the constructor, that these guys are
all aliasing the parent's base::TimeTicks. (I thought at first there was no way
this code worked.) I don't think we use const references that way. Could it be
switched to a pointer and also documented? (Or perhaps it gets plumbed through
somewhere else?)

[Deprecated (see juliatuttle), 2014/10/31 22:01:02]

I'll make it a pointer.

 
   base::WeakPtrFactory<DomainReliabilityContext> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(DomainReliabilityContext);
 };
 
 }  // namespace domain_reliability
 
 #endif  // COMPONENTS_DOMAIN_RELIABILITY_CONTEXT_H_