Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 690993003: Remove the hspace/vspace attributes on table (Closed)

Created:
6 years, 1 month ago by philipj_slow
Modified:
5 years, 10 months ago
Reviewers:
pdr.
CC:
blink-reviews, blink-reviews-html_chromium.org, dglazkov+blink
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Remove the hspace/vspace attributes on table Intent to Remove: https://groups.google.com/a/chromium.org/d/msg/blink-dev/1ZjuiWEj-Ww/NHFbIT6UB5kJ Leave the deprecation message in place for some time as it may help Web developers diagnose any regressions they see due to this change. There are many remaining tests for <table align=center>, for example: LayoutTests/fast/table/035.html LayoutTests/tables/mozilla/marvin/tables_align_center.html BUG=277080 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190025

Patch Set 1 #

Patch Set 2 : rebase #

Messages

Total messages: 9 (2 generated)
philipj_slow
rebase
5 years, 10 months ago (2015-02-09 08:53:48 UTC) #1
philipj_slow
PTAL
5 years, 10 months ago (2015-02-09 11:06:34 UTC) #3
philipj_slow
Ping other Philip :)
5 years, 10 months ago (2015-02-11 17:42:33 UTC) #4
pdr.
Sorry for the delay. Gardening took up more time than usual. LGTM
5 years, 10 months ago (2015-02-12 04:17:31 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/690993003/20001
5 years, 10 months ago (2015-02-12 04:18:23 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://src.chromium.org/viewvc/blink?view=rev&revision=190025
5 years, 10 months ago (2015-02-12 05:20:24 UTC) #8
philipj_slow
5 years, 10 months ago (2015-02-12 05:32:41 UTC) #9
Message was sent while issue was closed.
On 2015/02/12 04:17:31, pdr wrote:
> Sorry for the delay. Gardening took up more time than usual.

No problem, gardening takes priority!

Powered by Google App Engine
This is Rietveld 408576698