Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Side by Side Diff: Source/core/html/HTMLTableElement.cpp

Issue 690993003: Remove the hspace/vspace attributes on table (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebase Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « LayoutTests/platform/win/fast/table/table-hspace-align-center-expected.txt ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1997 Martin Jones (mjones@kde.org) 2 * Copyright (C) 1997 Martin Jones (mjones@kde.org)
3 * (C) 1997 Torben Weis (weis@kde.org) 3 * (C) 1997 Torben Weis (weis@kde.org)
4 * (C) 1998 Waldo Bastian (bastian@kde.org) 4 * (C) 1998 Waldo Bastian (bastian@kde.org)
5 * (C) 1999 Lars Knoll (knoll@kde.org) 5 * (C) 1999 Lars Knoll (knoll@kde.org)
6 * (C) 1999 Antti Koivisto (koivisto@kde.org) 6 * (C) 1999 Antti Koivisto (koivisto@kde.org)
7 * Copyright (C) 2003, 2004, 2005, 2006, 2008, 2010, 2011 Apple Inc. All rights reserved. 7 * Copyright (C) 2003, 2004, 2005, 2006, 2008, 2010, 2011 Apple Inc. All rights reserved.
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 286 matching lines...) Expand 10 before | Expand all | Expand 10 after
297 style->setProperty(CSSProperty(CSSPropertyBackgroundImage, imageValu e.release())); 297 style->setProperty(CSSProperty(CSSPropertyBackgroundImage, imageValu e.release()));
298 } 298 }
299 } else if (name == valignAttr) { 299 } else if (name == valignAttr) {
300 if (!value.isEmpty()) 300 if (!value.isEmpty())
301 addPropertyToPresentationAttributeStyle(style, CSSPropertyVerticalAl ign, value); 301 addPropertyToPresentationAttributeStyle(style, CSSPropertyVerticalAl ign, value);
302 } else if (name == cellspacingAttr) { 302 } else if (name == cellspacingAttr) {
303 if (!value.isEmpty()) 303 if (!value.isEmpty())
304 addHTMLLengthToStyle(style, CSSPropertyBorderSpacing, value); 304 addHTMLLengthToStyle(style, CSSPropertyBorderSpacing, value);
305 } else if (name == vspaceAttr) { 305 } else if (name == vspaceAttr) {
306 UseCounter::countDeprecation(document(), UseCounter::HTMLTableElementVsp ace); 306 UseCounter::countDeprecation(document(), UseCounter::HTMLTableElementVsp ace);
307 addHTMLLengthToStyle(style, CSSPropertyMarginTop, value);
308 addHTMLLengthToStyle(style, CSSPropertyMarginBottom, value);
309 } else if (name == hspaceAttr) { 307 } else if (name == hspaceAttr) {
310 UseCounter::countDeprecation(document(), UseCounter::HTMLTableElementHsp ace); 308 UseCounter::countDeprecation(document(), UseCounter::HTMLTableElementHsp ace);
311 addHTMLLengthToStyle(style, CSSPropertyMarginLeft, value);
312 addHTMLLengthToStyle(style, CSSPropertyMarginRight, value);
313 } else if (name == alignAttr) { 309 } else if (name == alignAttr) {
314 if (!value.isEmpty()) { 310 if (!value.isEmpty()) {
315 if (equalIgnoringCase(value, "center")) { 311 if (equalIgnoringCase(value, "center")) {
316 addPropertyToPresentationAttributeStyle(style, CSSPropertyWebkit MarginStart, CSSValueAuto); 312 addPropertyToPresentationAttributeStyle(style, CSSPropertyWebkit MarginStart, CSSValueAuto);
317 addPropertyToPresentationAttributeStyle(style, CSSPropertyWebkit MarginEnd, CSSValueAuto); 313 addPropertyToPresentationAttributeStyle(style, CSSPropertyWebkit MarginEnd, CSSValueAuto);
318 } else 314 } else
319 addPropertyToPresentationAttributeStyle(style, CSSPropertyFloat, value); 315 addPropertyToPresentationAttributeStyle(style, CSSPropertyFloat, value);
320 } 316 }
321 } else if (name == rulesAttr) { 317 } else if (name == rulesAttr) {
322 // The presence of a valid rules attribute causes border collapsing to b e enabled. 318 // The presence of a valid rules attribute causes border collapsing to b e enabled.
(...skipping 235 matching lines...) Expand 10 before | Expand all | Expand 10 after
558 return getAttribute(summaryAttr); 554 return getAttribute(summaryAttr);
559 } 555 }
560 556
561 void HTMLTableElement::trace(Visitor* visitor) 557 void HTMLTableElement::trace(Visitor* visitor)
562 { 558 {
563 visitor->trace(m_sharedCellStyle); 559 visitor->trace(m_sharedCellStyle);
564 HTMLElement::trace(visitor); 560 HTMLElement::trace(visitor);
565 } 561 }
566 562
567 } 563 }
OLDNEW
« no previous file with comments | « LayoutTests/platform/win/fast/table/table-hspace-align-center-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698