Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 690943003: Move network_connect code to ui/chromeos/network (Take 2) (Closed)

Created:
6 years, 1 month ago by stevenjb
Modified:
6 years, 1 month ago
Reviewers:
oshima, sadrul, tbarzic
CC:
chromium-reviews, dbeam+watch-options_chromium.org, sadrul, nkostylev+watch_chromium.org, oshima+watch_chromium.org, kalyank, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Move network_connect code to ui/chromeos/network (Take 2) Original CL: Review URL: https://codereview.chromium.org/686503002 BUG=425996 TBR=oshima, sadrul, tbarzic Committed: https://crrev.com/d0502304fdafb1d8bb21e7fd9c07443986e4792c Cr-Commit-Position: refs/heads/master@{#302142}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+267 lines, -1584 lines) Patch
M ash/ash.gyp View 2 chunks +0 lines, -5 lines 0 comments Download
M ash/ash_chromeos_strings.grdp View 2 chunks +0 lines, -110 lines 0 comments Download
M ash/resources/ash_resources.grd View 2 chunks +0 lines, -3 lines 0 comments Download
D ash/resources/default_100_percent/cros/network/notification_3g.png View Binary file 0 comments Download
D ash/resources/default_100_percent/cros/network/notification_lte.png View Binary file 0 comments Download
D ash/resources/default_100_percent/cros/network/status_cellular_failed.png View Binary file 0 comments Download
D ash/resources/default_200_percent/cros/network/notification_3g.png View Binary file 0 comments Download
D ash/resources/default_200_percent/cros/network/notification_lte.png View Binary file 0 comments Download
D ash/resources/default_200_percent/cros/network/status_cellular_failed.png View Binary file 0 comments Download
D ash/system/chromeos/network/network_connect.h View 1 chunk +0 lines, -115 lines 0 comments Download
D ash/system/chromeos/network/network_connect.cc View 1 chunk +0 lines, -648 lines 0 comments Download
M ash/system/chromeos/network/network_state_list_detailed_view.cc View 4 chunks +4 lines, -4 lines 0 comments Download
D ash/system/chromeos/network/network_state_notifier.h View 1 chunk +0 lines, -103 lines 0 comments Download
D ash/system/chromeos/network/network_state_notifier.cc View 1 chunk +0 lines, -363 lines 0 comments Download
D ash/system/chromeos/network/network_state_notifier_unittest.cc View 1 chunk +0 lines, -129 lines 0 comments Download
M ash/system/system_notifier.cc View 4 chunks +11 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/chrome_browser_main_chromeos.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/mobile/mobile_activator.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/options/vpn_config_view.cc View 5 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/options/wifi_config_view.cc View 5 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/options/wimax_config_view.cc View 4 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/status/data_promo_notification.cc View 4 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/status/network_menu.cc View 4 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/ash/network_connect_delegate_chromeos.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc View 7 chunks +6 lines, -6 lines 0 comments Download
M ui/base/BUILD.gn View 2 chunks +4 lines, -0 lines 0 comments Download
M ui/base/ui_base_tests.gypi View 1 chunk +5 lines, -1 line 0 comments Download
M ui/chromeos/BUILD.gn View 3 chunks +5 lines, -0 lines 0 comments Download
M ui/chromeos/DEPS View 2 chunks +2 lines, -0 lines 0 comments Download
A + ui/chromeos/network/network_connect.h View 3 chunks +7 lines, -7 lines 0 comments Download
A + ui/chromeos/network/network_connect.cc View 4 chunks +5 lines, -6 lines 0 comments Download
A + ui/chromeos/network/network_state_notifier.h View 5 chunks +9 lines, -7 lines 0 comments Download
A + ui/chromeos/network/network_state_notifier.cc View 7 chunks +16 lines, -14 lines 0 comments Download
A + ui/chromeos/network/network_state_notifier_unittest.cc View 5 chunks +18 lines, -30 lines 0 comments Download
A + ui/chromeos/resources/default_100_percent/network/notification_3g.png View Binary file 0 comments Download
A + ui/chromeos/resources/default_100_percent/network/notification_lte.png View Binary file 0 comments Download
A + ui/chromeos/resources/default_100_percent/network/status_cellular_failed.png View Binary file 0 comments Download
A + ui/chromeos/resources/default_200_percent/network/notification_3g.png View Binary file 0 comments Download
A + ui/chromeos/resources/default_200_percent/network/notification_lte.png View Binary file 0 comments Download
A + ui/chromeos/resources/default_200_percent/network/status_cellular_failed.png View Binary file 0 comments Download
M ui/chromeos/resources/ui_chromeos_resources.grd View 2 chunks +3 lines, -0 lines 0 comments Download
M ui/chromeos/ui_chromeos.gyp View 3 chunks +5 lines, -1 line 0 comments Download
M ui/chromeos/ui_chromeos_strings.grd View 1 chunk +111 lines, -0 lines 0 comments Download
M ui/resources/BUILD.gn View 2 chunks +14 lines, -0 lines 0 comments Download
M ui/resources/ui_resources.gyp View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/690943003/1
6 years, 1 month ago (2014-10-30 19:16:22 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-30 20:08:13 UTC) #3
commit-bot: I haz the power
6 years, 1 month ago (2014-10-30 20:08:54 UTC) #4
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/d0502304fdafb1d8bb21e7fd9c07443986e4792c
Cr-Commit-Position: refs/heads/master@{#302142}

Powered by Google App Engine
This is Rietveld 408576698