Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 686503002: Move network_connect code to ui/chromeos/network (Closed)

Created:
6 years, 1 month ago by stevenjb
Modified:
6 years, 1 month ago
CC:
chromium-reviews, dbeam+watch-options_chromium.org, sadrul, nkostylev+watch_chromium.org, ben+ash_chromium.org, oshima+watch_chromium.org, kalyank, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Move network_connect code to ui/chromeos/network BUG=425996 Committed: https://crrev.com/c49ac404f05590cd8834c5fe3db7915c02af6910 Cr-Commit-Position: refs/heads/master@{#302092}

Patch Set 1 #

Total comments: 10

Patch Set 2 : Update .gn files, feedback #

Total comments: 4

Patch Set 3 : Rebase + more gn fixes #

Total comments: 2

Patch Set 4 : Yet more gn fixes #

Total comments: 4

Patch Set 5 : Sort gyp files #

Patch Set 6 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+265 lines, -1584 lines) Patch
M ash/ash.gyp View 1 2 3 4 5 2 chunks +0 lines, -5 lines 0 comments Download
M ash/ash_chromeos_strings.grdp View 2 chunks +0 lines, -110 lines 0 comments Download
M ash/resources/ash_resources.grd View 2 chunks +0 lines, -3 lines 0 comments Download
D ash/resources/default_100_percent/cros/network/notification_3g.png View Binary file 0 comments Download
D ash/resources/default_100_percent/cros/network/notification_lte.png View Binary file 0 comments Download
D ash/resources/default_100_percent/cros/network/status_cellular_failed.png View Binary file 0 comments Download
D ash/resources/default_200_percent/cros/network/notification_3g.png View Binary file 0 comments Download
D ash/resources/default_200_percent/cros/network/notification_lte.png View Binary file 0 comments Download
D ash/resources/default_200_percent/cros/network/status_cellular_failed.png View Binary file 0 comments Download
D ash/system/chromeos/network/network_connect.h View 1 chunk +0 lines, -115 lines 0 comments Download
D ash/system/chromeos/network/network_connect.cc View 1 chunk +0 lines, -648 lines 0 comments Download
M ash/system/chromeos/network/network_state_list_detailed_view.cc View 4 chunks +4 lines, -4 lines 0 comments Download
D ash/system/chromeos/network/network_state_notifier.h View 1 chunk +0 lines, -103 lines 0 comments Download
D ash/system/chromeos/network/network_state_notifier.cc View 1 chunk +0 lines, -363 lines 0 comments Download
D ash/system/chromeos/network/network_state_notifier_unittest.cc View 1 chunk +0 lines, -129 lines 0 comments Download
M ash/system/system_notifier.cc View 4 chunks +11 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/chrome_browser_main_chromeos.cc View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/mobile/mobile_activator.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/options/vpn_config_view.cc View 5 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/options/wifi_config_view.cc View 5 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/options/wimax_config_view.cc View 4 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/status/data_promo_notification.cc View 4 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/status/network_menu.cc View 4 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/ash/network_connect_delegate_chromeos.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc View 1 2 3 4 5 7 chunks +6 lines, -6 lines 0 comments Download
M ui/base/BUILD.gn View 1 2 3 4 2 chunks +4 lines, -0 lines 0 comments Download
M ui/base/ui_base_tests.gypi View 1 2 3 4 1 chunk +5 lines, -1 line 0 comments Download
M ui/chromeos/BUILD.gn View 1 2 chunks +4 lines, -0 lines 0 comments Download
M ui/chromeos/DEPS View 2 chunks +2 lines, -0 lines 0 comments Download
A + ui/chromeos/network/network_connect.h View 3 chunks +7 lines, -7 lines 0 comments Download
A + ui/chromeos/network/network_connect.cc View 1 4 chunks +5 lines, -6 lines 0 comments Download
A + ui/chromeos/network/network_state_notifier.h View 5 chunks +9 lines, -7 lines 0 comments Download
A + ui/chromeos/network/network_state_notifier.cc View 1 7 chunks +16 lines, -14 lines 0 comments Download
A + ui/chromeos/network/network_state_notifier_unittest.cc View 5 chunks +18 lines, -30 lines 0 comments Download
A + ui/chromeos/resources/default_100_percent/network/notification_3g.png View Binary file 0 comments Download
A + ui/chromeos/resources/default_100_percent/network/notification_lte.png View Binary file 0 comments Download
A + ui/chromeos/resources/default_100_percent/network/status_cellular_failed.png View Binary file 0 comments Download
A + ui/chromeos/resources/default_200_percent/network/notification_3g.png View Binary file 0 comments Download
A + ui/chromeos/resources/default_200_percent/network/notification_lte.png View Binary file 0 comments Download
A + ui/chromeos/resources/default_200_percent/network/status_cellular_failed.png View Binary file 0 comments Download
M ui/chromeos/resources/ui_chromeos_resources.grd View 2 chunks +3 lines, -0 lines 0 comments Download
M ui/chromeos/ui_chromeos.gyp View 2 chunks +4 lines, -1 line 0 comments Download
M ui/chromeos/ui_chromeos_strings.grd View 1 chunk +111 lines, -0 lines 0 comments Download
M ui/resources/BUILD.gn View 1 2 2 chunks +14 lines, -0 lines 0 comments Download
M ui/resources/ui_resources.gyp View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (4 generated)
stevenjb
6 years, 1 month ago (2014-10-27 20:24:53 UTC) #2
tbarzic
lgtm https://codereview.chromium.org/686503002/diff/1/ui/chromeos/network/network_state_notifier.cc File ui/chromeos/network/network_state_notifier.cc (right): https://codereview.chromium.org/686503002/diff/1/ui/chromeos/network/network_state_notifier.cc#newcode83 ui/chromeos/network/network_state_notifier.cc:83: nuke one line
6 years, 1 month ago (2014-10-27 20:58:42 UTC) #3
oshima
https://codereview.chromium.org/686503002/diff/1/ui/base/ui_base_tests.gypi File ui/base/ui_base_tests.gypi (right): https://codereview.chromium.org/686503002/diff/1/ui/base/ui_base_tests.gypi#newcode202 ui/base/ui_base_tests.gypi:202: '../chromeos/network/network_state_notifier_unittest.cc', don't you have to make similar changes to ...
6 years, 1 month ago (2014-10-27 22:17:20 UTC) #4
stevenjb
PTAL https://codereview.chromium.org/686503002/diff/1/ui/base/ui_base_tests.gypi File ui/base/ui_base_tests.gypi (right): https://codereview.chromium.org/686503002/diff/1/ui/base/ui_base_tests.gypi#newcode202 ui/base/ui_base_tests.gypi:202: '../chromeos/network/network_state_notifier_unittest.cc', On 2014/10/27 22:17:20, oshima wrote: > don't ...
6 years, 1 month ago (2014-10-29 20:44:55 UTC) #5
oshima
https://codereview.chromium.org/686503002/diff/1/ui/base/ui_base_tests.gypi File ui/base/ui_base_tests.gypi (right): https://codereview.chromium.org/686503002/diff/1/ui/base/ui_base_tests.gypi#newcode202 ui/base/ui_base_tests.gypi:202: '../chromeos/network/network_state_notifier_unittest.cc', On 2014/10/29 20:44:55, stevenjb wrote: > On 2014/10/27 ...
6 years, 1 month ago (2014-10-29 21:06:04 UTC) #6
stevenjb
+sadrul@ PTAL https://codereview.chromium.org/686503002/diff/1/ui/base/ui_base_tests.gypi File ui/base/ui_base_tests.gypi (right): https://codereview.chromium.org/686503002/diff/1/ui/base/ui_base_tests.gypi#newcode202 ui/base/ui_base_tests.gypi:202: '../chromeos/network/network_state_notifier_unittest.cc', On 2014/10/29 21:06:04, oshima wrote: > ...
6 years, 1 month ago (2014-10-29 21:21:06 UTC) #8
oshima
https://codereview.chromium.org/686503002/diff/40001/ui/base/ui_base_tests.gypi File ui/base/ui_base_tests.gypi (right): https://codereview.chromium.org/686503002/diff/40001/ui/base/ui_base_tests.gypi#newcode198 ui/base/ui_base_tests.gypi:198: '../message_center/message_center.gyp:message_center', don't you have to add these dependencies in ...
6 years, 1 month ago (2014-10-29 21:29:06 UTC) #9
stevenjb
https://codereview.chromium.org/686503002/diff/40001/ui/base/ui_base_tests.gypi File ui/base/ui_base_tests.gypi (right): https://codereview.chromium.org/686503002/diff/40001/ui/base/ui_base_tests.gypi#newcode198 ui/base/ui_base_tests.gypi:198: '../message_center/message_center.gyp:message_center', On 2014/10/29 21:29:05, oshima wrote: > don't you ...
6 years, 1 month ago (2014-10-29 22:07:47 UTC) #10
stevenjb
On 2014/10/29 22:07:47, stevenjb wrote: > https://codereview.chromium.org/686503002/diff/40001/ui/base/ui_base_tests.gypi > File ui/base/ui_base_tests.gypi (right): > > https://codereview.chromium.org/686503002/diff/40001/ui/base/ui_base_tests.gypi#newcode198 > ...
6 years, 1 month ago (2014-10-29 22:09:04 UTC) #11
oshima
On 2014/10/29 22:09:04, stevenjb wrote: > On 2014/10/29 22:07:47, stevenjb wrote: > > > https://codereview.chromium.org/686503002/diff/40001/ui/base/ui_base_tests.gypi ...
6 years, 1 month ago (2014-10-29 22:29:28 UTC) #12
oshima
lgtm
6 years, 1 month ago (2014-10-29 22:29:59 UTC) #13
sadrul
LGTM https://codereview.chromium.org/686503002/diff/60001/ui/base/BUILD.gn File ui/base/BUILD.gn (right): https://codereview.chromium.org/686503002/diff/60001/ui/base/BUILD.gn#newcode891 ui/base/BUILD.gn:891: "../chromeos/network/network_state_notifier_unittest.cc", sort https://codereview.chromium.org/686503002/diff/60001/ui/base/ui_base_tests.gypi File ui/base/ui_base_tests.gypi (right): https://codereview.chromium.org/686503002/diff/60001/ui/base/ui_base_tests.gypi#newcode202 ui/base/ui_base_tests.gypi:202: ...
6 years, 1 month ago (2014-10-30 14:58:40 UTC) #14
stevenjb
https://codereview.chromium.org/686503002/diff/60001/ui/base/BUILD.gn File ui/base/BUILD.gn (right): https://codereview.chromium.org/686503002/diff/60001/ui/base/BUILD.gn#newcode891 ui/base/BUILD.gn:891: "../chromeos/network/network_state_notifier_unittest.cc", On 2014/10/30 14:58:40, sadrul wrote: > sort Done. ...
6 years, 1 month ago (2014-10-30 15:36:20 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/686503002/100001
6 years, 1 month ago (2014-10-30 15:52:40 UTC) #17
commit-bot: I haz the power
Committed patchset #6 (id:100001)
6 years, 1 month ago (2014-10-30 16:44:00 UTC) #18
commit-bot: I haz the power
Patchset 6 (id:??) landed as https://crrev.com/c49ac404f05590cd8834c5fe3db7915c02af6910 Cr-Commit-Position: refs/heads/master@{#302092}
6 years, 1 month ago (2014-10-30 16:44:45 UTC) #19
binjin
6 years, 1 month ago (2014-10-30 17:36:38 UTC) #21
Message was sent while issue was closed. 
This CL is reverted by https://codereview.chromium.org/693493003

Powered by Google App Engine
This is Rietveld 408576698