Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 690923004: TrackEvent.track should be (VideoTrack or AudioTrack or TextTrack)? (Closed)

Created:
6 years, 1 month ago by bashi
Modified:
6 years, 1 month ago
Reviewers:
haraken, sof
CC:
blink-reviews, nessy, arv+blink, blink-reviews-html_chromium.org, gasubic, fs, eric.carlson_apple.com, dglazkov+blink, blink-reviews-bindings_chromium.org, Inactive, vcarbune.chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

TrackEvent.track should be (VideoTrack or AudioTrack or TextTrack)? Track attribute uses object type, but we should use (VideoTrack or AudioTrack or TextTrak)? as the spec says[1]. [1] https://html.spec.whatwg.org/multipage/embedded-content.html#the-trackevent-interface BUG=430337 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185104

Patch Set 1 : #

Total comments: 2

Patch Set 2 : #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -81 lines) Patch
M LayoutTests/fast/events/constructors/track-event-constructor-expected.txt View 1 chunk +7 lines, -7 lines 3 comments Download
D Source/bindings/core/v8/custom/V8TrackEventCustom.cpp View 1 chunk +0 lines, -69 lines 0 comments Download
M Source/bindings/core/v8/custom/custom.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/track/TrackEvent.h View 2 chunks +3 lines, -1 line 0 comments Download
M Source/core/html/track/TrackEvent.cpp View 1 2 chunks +25 lines, -1 line 0 comments Download
M Source/core/html/track/TrackEvent.idl View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (4 generated)
bashi
PTAL?
6 years, 1 month ago (2014-11-11 04:01:02 UTC) #3
haraken
LGTM https://codereview.chromium.org/690923004/diff/20001/Source/core/html/track/TrackEvent.cpp File Source/core/html/track/TrackEvent.cpp (right): https://codereview.chromium.org/690923004/diff/20001/Source/core/html/track/TrackEvent.cpp#newcode74 Source/core/html/track/TrackEvent.cpp:74: break; Add: default: ASSERT_NOT_REACHED();
6 years, 1 month ago (2014-11-11 04:50:24 UTC) #4
bashi
Thank you for review! https://codereview.chromium.org/690923004/diff/20001/Source/core/html/track/TrackEvent.cpp File Source/core/html/track/TrackEvent.cpp (right): https://codereview.chromium.org/690923004/diff/20001/Source/core/html/track/TrackEvent.cpp#newcode74 Source/core/html/track/TrackEvent.cpp:74: break; On 2014/11/11 04:50:23, haraken ...
6 years, 1 month ago (2014-11-11 05:02:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/690923004/40001
6 years, 1 month ago (2014-11-11 05:03:19 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:40001) as 185104
6 years, 1 month ago (2014-11-11 06:09:12 UTC) #8
philipj_slow
Nice!
6 years, 1 month ago (2014-11-11 09:11:19 UTC) #9
sof
https://codereview.chromium.org/690923004/diff/40001/LayoutTests/fast/events/constructors/track-event-constructor-expected.txt File LayoutTests/fast/events/constructors/track-event-constructor-expected.txt (right): https://codereview.chromium.org/690923004/diff/40001/LayoutTests/fast/events/constructors/track-event-constructor-expected.txt#newcode26 LayoutTests/fast/events/constructors/track-event-constructor-expected.txt:26: PASS new TrackEvent('TrackEvent', { track: document }).track threw exception ...
6 years, 1 month ago (2014-11-11 11:02:26 UTC) #10
bashi
https://codereview.chromium.org/690923004/diff/40001/LayoutTests/fast/events/constructors/track-event-constructor-expected.txt File LayoutTests/fast/events/constructors/track-event-constructor-expected.txt (right): https://codereview.chromium.org/690923004/diff/40001/LayoutTests/fast/events/constructors/track-event-constructor-expected.txt#newcode26 LayoutTests/fast/events/constructors/track-event-constructor-expected.txt:26: PASS new TrackEvent('TrackEvent', { track: document }).track threw exception ...
6 years, 1 month ago (2014-11-11 23:19:34 UTC) #11
sof
https://codereview.chromium.org/690923004/diff/40001/LayoutTests/fast/events/constructors/track-event-constructor-expected.txt File LayoutTests/fast/events/constructors/track-event-constructor-expected.txt (right): https://codereview.chromium.org/690923004/diff/40001/LayoutTests/fast/events/constructors/track-event-constructor-expected.txt#newcode26 LayoutTests/fast/events/constructors/track-event-constructor-expected.txt:26: PASS new TrackEvent('TrackEvent', { track: document }).track threw exception ...
6 years, 1 month ago (2014-11-12 06:05:43 UTC) #13
bashi
6 years, 1 month ago (2014-11-12 07:41:45 UTC) #14
Message was sent while issue was closed.
On 2014/11/12 06:05:43, sof wrote:
>
https://codereview.chromium.org/690923004/diff/40001/LayoutTests/fast/events/...
> File LayoutTests/fast/events/constructors/track-event-constructor-expected.txt
> (right):
> 
>
https://codereview.chromium.org/690923004/diff/40001/LayoutTests/fast/events/...
> LayoutTests/fast/events/constructors/track-event-constructor-expected.txt:26:
> PASS new TrackEvent('TrackEvent', { track: document }).track threw exception
> TypeError: Failed to construct 'TrackEvent': The 'track' property does not
have
> a VideoTrackOrAudioTrackOrTextTrack type..
> On 2014/11/11 23:19:33, bashi1 wrote:
> > On 2014/11/11 11:02:26, sof wrote:
> > > Possible to make the 'conversion type' of the Dictionary use the IDL type
> > > instead?
> > 
> > You mean using "VideoTrackOrAudioTrackOrTextTrackOrNull" here?
> 
> "(VideoTrack or AudioTrack or TextTrack)" - the suggestion is to avoid
exposing
> internal type names in user-facing error messages.

Ah, I see. "VideoTrackOrAudioTrackOrTextTrackOrNull" is the IDL type name
according to the spec[1].
[1] http://heycam.github.io/webidl/#idl-union

Anyway, showing it wouldn't look great to users. I'll try to follow your
suggestion:)

Powered by Google App Engine
This is Rietveld 408576698