LayoutTests/fast/events/constructors/track-event-constructor-expected.txt - Issue 690923004: TrackEvent.track should be (VideoTrack or AudioTrack or TextTrack)?

Side by Side Diff: LayoutTests/fast/events/constructors/track-event-constructor-expected.txt

Issue 690923004: TrackEvent.track should be (VideoTrack or AudioTrack or TextTrack)? (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | Source/bindings/core/v8/custom/V8TrackEventCustom.cpp » ('j') | no next file with comments »

OLD	NEW
1 This tests the constructor for the TrackEvent DOM class.	1 This tests the constructor for the TrackEvent DOM class.

2	2

3 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE ".	3 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE ".

4	4

5	5

6	6

7 * No initializer passed *	7 * No initializer passed *

8 PASS new TrackEvent('TrackEvent').bubbles is false	8 PASS new TrackEvent('TrackEvent').bubbles is false

9 PASS new TrackEvent('TrackEvent').cancelable is false	9 PASS new TrackEvent('TrackEvent').cancelable is false

10 PASS new TrackEvent('TrackEvent').track is null	10 PASS new TrackEvent('TrackEvent').track is null

11	11

12 * Bubbles and cancelable true, track is missing *	12 * Bubbles and cancelable true, track is missing *

13 PASS new TrackEvent('TrackEvent', { bubbles: true, cancelable: true }).bubbles i s true	13 PASS new TrackEvent('TrackEvent', { bubbles: true, cancelable: true }).bubbles i s true

14 PASS new TrackEvent('TrackEvent', { bubbles: true, cancelable: true }).cancelabl e is true	14 PASS new TrackEvent('TrackEvent', { bubbles: true, cancelable: true }).cancelabl e is true

15 PASS new TrackEvent('TrackEvent', { bubbles: true, cancelable: true }).track is null	15 PASS new TrackEvent('TrackEvent', { bubbles: true, cancelable: true }).track is null

16	16

17 * Bubbles and cancelable true, invalid track *	17 * Bubbles and cancelable true, invalid track *

18 PASS new TrackEvent('TrackEvent', { bubbles: true, cancelable: true, track: HTML TrackElement }).bubbles threw exception TypeError: Failed to construct 'TrackEve nt': The 'track' property does not have a object type..	18 PASS new TrackEvent('TrackEvent', { bubbles: true, cancelable: true, track: HTML TrackElement }).bubbles threw exception TypeError: Failed to construct 'TrackEve nt': The 'track' property does not have a VideoTrackOrAudioTrackOrTextTrack type ..

19 PASS new TrackEvent('TrackEvent', { bubbles: true, cancelable: true, track: HTML TrackElement }).cancelable threw exception TypeError: Failed to construct 'Track Event': The 'track' property does not have a object type..	19 PASS new TrackEvent('TrackEvent', { bubbles: true, cancelable: true, track: HTML TrackElement }).cancelable threw exception TypeError: Failed to construct 'Track Event': The 'track' property does not have a VideoTrackOrAudioTrackOrTextTrack t ype..

20 PASS new TrackEvent('TrackEvent', { bubbles: true, cancelable: true, track: HTML TrackElement }).track threw exception TypeError: Failed to construct 'TrackEvent ': The 'track' property does not have a object type..	20 PASS new TrackEvent('TrackEvent', { bubbles: true, cancelable: true, track: HTML TrackElement }).track threw exception TypeError: Failed to construct 'TrackEvent ': The 'track' property does not have a VideoTrackOrAudioTrackOrTextTrack type..

21	21

22 * Initialize 'track' with a invalid values *	22 * Initialize 'track' with a invalid values *

23 PASS new TrackEvent('TrackEvent', { track: 10 }).track threw exception TypeError : Failed to construct 'TrackEvent': The 'track' property does not have a object type..	23 PASS new TrackEvent('TrackEvent', { track: 10 }).track threw exception TypeError : Failed to construct 'TrackEvent': The 'track' property does not have a VideoTr ackOrAudioTrackOrTextTrack type..

24 PASS new TrackEvent('TrackEvent', { track: 'string' }).track threw exception Typ eError: Failed to construct 'TrackEvent': The 'track' property does not have a o bject type..	24 PASS new TrackEvent('TrackEvent', { track: 'string' }).track threw exception Typ eError: Failed to construct 'TrackEvent': The 'track' property does not have a V ideoTrackOrAudioTrackOrTextTrack type..

25 PASS new TrackEvent('TrackEvent', { track: emptyObject }).track threw exception TypeError: Failed to construct 'TrackEvent': The 'track' property does not have a object type..	25 PASS new TrackEvent('TrackEvent', { track: emptyObject }).track threw exception TypeError: Failed to construct 'TrackEvent': The 'track' property does not have a VideoTrackOrAudioTrackOrTextTrack type..

26 PASS new TrackEvent('TrackEvent', { track: document }).track threw exception Typ eError: Failed to construct 'TrackEvent': The 'track' property does not have a o bject type..	26 PASS new TrackEvent('TrackEvent', { track: document }).track threw exception Typ eError: Failed to construct 'TrackEvent': The 'track' property does not have a V ideoTrackOrAudioTrackOrTextTrack type..
	sof 2014/11/11 11:02:26 Possible to make the 'conversion type' of the Dict Possible to make the 'conversion type' of the Dictionary use the IDL type instead? bashi 2014/11/11 23:19:33 You mean using "VideoTrackOrAudioTrackOrTextTrackO Show quoted text On 2014/11/11 11:02:26, sof wrote: > Possible to make the 'conversion type' of the Dictionary use the IDL type > instead? You mean using "VideoTrackOrAudioTrackOrTextTrackOrNull" here? sof 2014/11/12 06:05:43 "(VideoTrack or AudioTrack or TextTrack)" - the su Show quoted text On 2014/11/11 23:19:33, bashi1 wrote: > On 2014/11/11 11:02:26, sof wrote: > > Possible to make the 'conversion type' of the Dictionary use the IDL type > > instead? > > You mean using "VideoTrackOrAudioTrackOrTextTrackOrNull" here? "(VideoTrack or AudioTrack or TextTrack)" - the suggestion is to avoid exposing internal type names in user-facing error messages.
27	27

28 * Bubbles and cancelable true, valid track *	28 * Bubbles and cancelable true, valid track *

29 PASS new TrackEvent('TrackEvent', { bubbles: true, cancelable: true, track: trac kElement.track }).bubbles is true	29 PASS new TrackEvent('TrackEvent', { bubbles: true, cancelable: true, track: trac kElement.track }).bubbles is true

30 PASS new TrackEvent('TrackEvent', { bubbles: true, cancelable: true, track: trac kElement.track }).cancelable is true	30 PASS new TrackEvent('TrackEvent', { bubbles: true, cancelable: true, track: trac kElement.track }).cancelable is true

31 PASS new TrackEvent('TrackEvent', { track: trackElement.track }).track is trackE lement.track	31 PASS new TrackEvent('TrackEvent', { track: trackElement.track }).track is trackE lement.track

32	32

33 * Initialize 'track' with valid track object *	33 * Initialize 'track' with valid track object *

34 PASS new TrackEvent('TrackEvent', { track: trackElement.track }).track is trackE lement.track	34 PASS new TrackEvent('TrackEvent', { track: trackElement.track }).track is trackE lement.track

35	35

36 PASS successfullyParsed is true	36 PASS successfullyParsed is true

37	37

38 TEST COMPLETE	38 TEST COMPLETE

39	39

OLD	NEW