Remove timing limitation of SetOption invocation for PPAPI sockets.

ppapi/proxy/udp_socket_resource_base.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef PPAPI_PROXY_UDP_SOCKET_RESOURCE_BASE_H_
 #define PPAPI_PROXY_UDP_SOCKET_RESOURCE_BASE_H_
 
 #include <queue>
 #include <string>
 
@@ skipping 36 matching lines @@
   static const size_t kPluginReceiveBufferSlots;
 
  protected:
   UDPSocketResourceBase(Connection connection,
                         PP_Instance instance,
                         bool private_api);
   virtual ~UDPSocketResourceBase();
 
   int32_t SetOptionImpl(PP_UDPSocket_Option name,
                         const PP_Var& value,
+                        bool check_bind_state,
                         scoped_refptr<TrackedCallback> callback);
   int32_t BindImpl(const PP_NetAddress_Private* addr,
                    scoped_refptr<TrackedCallback> callback);
   PP_Bool GetBoundAddressImpl(PP_NetAddress_Private* addr);
   // |addr| could be NULL to indicate that an output value is not needed.
   int32_t RecvFromImpl(char* buffer,
                        int32_t num_bytes,
                        PP_Resource* addr,
                        scoped_refptr<TrackedCallback> callback);
   PP_Bool GetRecvFromAddressImpl(PP_NetAddress_Private* addr);
@@ skipping 32 matching lines @@
 
   // Callers must ensure that |output_buffer| is big enough to store |data|.
   int32_t SetRecvFromOutput(int32_t browser_result,
                             const std::string& data,
                             const PP_NetAddress_Private& addr,
                             char* output_buffer,
                             int32_t num_bytes,
                             PP_Resource* output_addr);
 
   bool private_api_;
+
+  // |bind_called_| is true if Bind() is called, while |bound_| is true,

[bbudge, 2014/12/09 18:37:38]

nit: s/if /after
I think the comment would be slightly easier to read that way.

[hidehiko, 2014/12/09 19:51:42]

Done.

+  // after Bind() succeeds. Bind() is an asynchronous method, so the timing
+  // on which of these is set is slightly different.
+  bool bind_called_;
   bool bound_;
   bool closed_;
 
   scoped_refptr<TrackedCallback> bind_callback_;
   scoped_refptr<TrackedCallback> recvfrom_callback_;
   scoped_refptr<TrackedCallback> sendto_callback_;
 
   char* read_buffer_;
   int32_t bytes_to_read_;
   PP_Resource* recvfrom_addr_resource_;
 
   PP_NetAddress_Private recvfrom_addr_;
   PP_NetAddress_Private bound_addr_;
 
   std::queue<RecvBuffer> recv_buffers_;
 
   DISALLOW_COPY_AND_ASSIGN(UDPSocketResourceBase);
 };
 
 }  // namespace proxy
 }  // namespace ppapi
 
 #endif  // PPAPI_PROXY_UDP_SOCKET_RESOURCE_BASE_H_