Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Unified Diff: ppapi/proxy/tcp_socket_private_resource.cc

Issue 690903002: Remove timing limitation of SetOption invocation for PPAPI sockets. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase and fixed implementation. Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ppapi/proxy/tcp_socket_private_resource.cc
diff --git a/ppapi/proxy/tcp_socket_private_resource.cc b/ppapi/proxy/tcp_socket_private_resource.cc
index 76ed4b9e1e2998ce3dc6c2fcee8c67e1abaef01d..454c3faf1a374a89420c2b541d6139ba2802d1dc 100644
--- a/ppapi/proxy/tcp_socket_private_resource.cc
+++ b/ppapi/proxy/tcp_socket_private_resource.cc
@@ -101,7 +101,9 @@ int32_t TCPSocketPrivateResource::SetOption(
case PP_TCPSOCKETOPTION_PRIVATE_INVALID:
return PP_ERROR_BADARGUMENT;
case PP_TCPSOCKETOPTION_PRIVATE_NO_DELAY:
- return SetOptionImpl(PP_TCPSOCKET_OPTION_NO_DELAY, value, callback);
+ return SetOptionImpl(PP_TCPSOCKET_OPTION_NO_DELAY, value,
+ true, // Check connect() state.
+ callback);
default:
NOTREACHED();
return PP_ERROR_BADARGUMENT;

Powered by Google App Engine
This is Rietveld 408576698