Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(923)

Unified Diff: content/browser/renderer_host/pepper/pepper_udp_socket_message_filter.h

Issue 690903002: Remove timing limitation of SetOption invocation for PPAPI sockets. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/pepper/pepper_udp_socket_message_filter.h
diff --git a/content/browser/renderer_host/pepper/pepper_udp_socket_message_filter.h b/content/browser/renderer_host/pepper/pepper_udp_socket_message_filter.h
index 1aa2c36cad499c72132194fc0560c5e7ff68e7b8..05f887b9eee87f4fd98ec0e35ce052014b0fc149 100644
--- a/content/browser/renderer_host/pepper/pepper_udp_socket_message_filter.h
+++ b/content/browser/renderer_host/pepper/pepper_udp_socket_message_filter.h
@@ -56,6 +56,13 @@ class CONTENT_EXPORT PepperUDPSocketMessageFilter
~PepperUDPSocketMessageFilter() override;
private:
+ enum SocketOption {
+ SOCKET_OPTION_ADDRESS_REUSE = 1 << 0,
+ SOCKET_OPTION_BROADCAST = 1 << 1,
+ SOCKET_OPTION_RCVBUF_SIZE = 1 << 2,
+ SOCKET_OPTION_SNDBUF_SIZE = 1 << 3
+ };
+
// ppapi::host::ResourceMessageFilter overrides.
scoped_refptr<base::TaskRunner> OverrideTaskRunnerForMessage(
const IPC::Message& message) override;
@@ -103,8 +110,10 @@ class CONTENT_EXPORT PepperUDPSocketMessageFilter
void SendSendToError(const ppapi::host::ReplyMessageContext& context,
int32_t result);
- bool allow_address_reuse_;
- bool allow_broadcast_;
+ // Bitwise-or of SocketOption, which is set before Bind().
bbudge 2014/11/07 17:50:39 To make the comment a little clearer, how about th
hidehiko 2014/11/07 21:13:55 Done.
+ int socket_options_;
+ int32 rcvbuf_size_;
+ int32 sndbuf_size_;
scoped_ptr<net::UDPServerSocket> socket_;
bool closed_;

Powered by Google App Engine
This is Rietveld 408576698