Remove timing limitation of SetOption invocation for PPAPI sockets.

content/browser/renderer_host/pepper/pepper_udp_socket_message_filter.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_RENDERER_HOST_PEPPER_PEPPER_UDP_SOCKET_MESSAGE_FILTER_H_
 #define CONTENT_BROWSER_RENDERER_HOST_PEPPER_PEPPER_UDP_SOCKET_MESSAGE_FILTER_H_
 
 #include <string>
 
 #include "base/basictypes.h"
@@ skipping 38 matching lines @@
   PepperUDPSocketMessageFilter(BrowserPpapiHostImpl* host,
                                PP_Instance instance,
                                bool private_api);
 
   static size_t GetNumInstances();
 
  protected:
   ~PepperUDPSocketMessageFilter() override;
 
  private:
+  enum SocketOption {
+    SOCKET_OPTION_ADDRESS_REUSE = 1 << 0,
+    SOCKET_OPTION_BROADCAST     = 1 << 1,
+    SOCKET_OPTION_RCVBUF_SIZE   = 1 << 2,
+    SOCKET_OPTION_SNDBUF_SIZE   = 1 << 3
+  };
+
   // ppapi::host::ResourceMessageFilter overrides.
   scoped_refptr<base::TaskRunner> OverrideTaskRunnerForMessage(
       const IPC::Message& message) override;
   int32_t OnResourceMessageReceived(
       const IPC::Message& msg,
       ppapi::host::HostMessageContext* context) override;
 
   int32_t OnMsgSetOption(const ppapi::host::HostMessageContext* context,
                          PP_UDPSocket_Option name,
                          const ppapi::SocketOptionData& value);
@@ skipping 27 matching lines @@
   void SendSendToReply(const ppapi::host::ReplyMessageContext& context,
                        int32_t result,
                        int32_t bytes_written);
 
   void SendBindError(const ppapi::host::ReplyMessageContext& context,
                      int32_t result);
   void SendRecvFromError(int32_t result);
   void SendSendToError(const ppapi::host::ReplyMessageContext& context,
                        int32_t result);
 
-  bool allow_address_reuse_;
-  bool allow_broadcast_;
+  // Bitwise-or of SocketOption, which is set before Bind().

[bbudge, 2014/11/07 17:50:39]

To make the comment a little clearer, how about this?

// Bitwise-or of SocketOption flags. This stores the state about whether
// each option is set before Bind() is called.

[hidehiko, 2014/11/07 21:13:55]

Done.

+  int socket_options_;
+  int32 rcvbuf_size_;
+  int32 sndbuf_size_;
 
   scoped_ptr<net::UDPServerSocket> socket_;
   bool closed_;
 
   scoped_refptr<net::IOBuffer> recvfrom_buffer_;
   scoped_refptr<net::IOBufferWithSize> sendto_buffer_;
 
   net::IPEndPoint recvfrom_address_;
 
   size_t remaining_recv_slots_;
 
   bool external_plugin_;
   bool private_api_;
 
   int render_process_id_;
   int render_frame_id_;
 
   DISALLOW_COPY_AND_ASSIGN(PepperUDPSocketMessageFilter);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_RENDERER_HOST_PEPPER_PEPPER_UDP_SOCKET_MESSAGE_FILTER_H_