ppapi/proxy/udp_socket_resource_base.cc - Issue 690903002: Remove timing limitation of SetOption invocation for PPAPI sockets.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ppapi/proxy/udp_socket_resource_base.cc

Issue 690903002: Remove timing limitation of SetOption invocation for PPAPI sockets. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/renderer_host/pepper/pepper_tcp_socket_message_filter.h ('K') | « ppapi/proxy/tcp_socket_resource_base.cc ('k') | ppapi/tests/test_tcp_socket.cc » ('j') | ppapi/tests/test_udp_socket.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ppapi/proxy/udp_socket_resource_base.cc

diff --git a/ppapi/proxy/udp_socket_resource_base.cc b/ppapi/proxy/udp_socket_resource_base.cc

index 521a6e2f4e284220d649e8d49934f503b6245127..7d2a074a2c614d74329e2e85a1ce678a63d68eb1 100644

--- a/ppapi/proxy/udp_socket_resource_base.cc

+++ b/ppapi/proxy/udp_socket_resource_base.cc

@@ -69,8 +69,6 @@ int32_t UDPSocketResourceBase::SetOptionImpl(

switch (name) {

case PP_UDPSOCKET_OPTION_ADDRESS_REUSE:

case PP_UDPSOCKET_OPTION_BROADCAST: {

- if (bound_)

- return PP_ERROR_FAILED;

if (value.type != PP_VARTYPE_BOOL)

return PP_ERROR_BADARGUMENT;

option_data.SetBool(PP_ToBool(value.value.as_bool));

@@ -78,8 +76,6 @@ int32_t UDPSocketResourceBase::SetOptionImpl(

}

case PP_UDPSOCKET_OPTION_SEND_BUFFER_SIZE:

case PP_UDPSOCKET_OPTION_RECV_BUFFER_SIZE: {

- if (!bound_)

- return PP_ERROR_FAILED;

if (value.type != PP_VARTYPE_INT32)

return PP_ERROR_BADARGUMENT;

option_data.SetInt32(value.value.as_int);