 Chromium Code Reviews
 Chromium Code Reviews Issue 690903002:
  Remove timing limitation of SetOption invocation for PPAPI sockets.  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/src.git@master
    
  
    Issue 690903002:
  Remove timing limitation of SetOption invocation for PPAPI sockets.  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/src.git@master| Index: content/browser/renderer_host/pepper/pepper_tcp_socket_message_filter.h | 
| diff --git a/content/browser/renderer_host/pepper/pepper_tcp_socket_message_filter.h b/content/browser/renderer_host/pepper/pepper_tcp_socket_message_filter.h | 
| index 7c9250f48995bc4e6fd35d377c06dc9da08e5294..2921f0500fed4a174e9ba5538a471ae5b5069b37 100644 | 
| --- a/content/browser/renderer_host/pepper/pepper_tcp_socket_message_filter.h | 
| +++ b/content/browser/renderer_host/pepper/pepper_tcp_socket_message_filter.h | 
| @@ -63,6 +63,12 @@ class CONTENT_EXPORT PepperTCPSocketMessageFilter | 
| static size_t GetNumInstances(); | 
| private: | 
| + enum SocketOptions { | 
| 
bbudge
2014/11/06 01:27:55
nit: Make this consistent with UDP name (SocketOpt
 
hidehiko
2014/11/06 14:13:21
Done.
 | 
| + SOCKET_OPTION_NODELAY = 1 << 0, | 
| + SOCKET_OPTION_RCVBUF_SIZE = 1 << 1, | 
| + SOCKET_OPTION_SNDBUF_SIZE = 1 << 2 | 
| + }; | 
| + | 
| ~PepperTCPSocketMessageFilter() override; | 
| // ppapi::host::ResourceMessageFilter overrides. | 
| @@ -185,6 +191,14 @@ class CONTENT_EXPORT PepperTCPSocketMessageFilter | 
| scoped_ptr<net::SingleRequestHostResolver> resolver_; | 
| + // Bitwise-or of SocketOption flags. This stores the state about whether | 
| 
bbudge
2014/11/06 01:27:55
nit: doesn't match enum name above.
 
hidehiko
2014/11/06 14:13:21
Acknowledged.
 | 
| + // each option is set. | 
| + int socket_options_; | 
| + | 
| + // Locally cached value of buffer size. | 
| + int32_t rcvbuf_size_; | 
| + int32_t sndbuf_size_; | 
| + | 
| // |address_list_| may store multiple addresses when | 
| // PPB_TCPSocket_Private.Connect() is used, which involves name resolution. | 
| // In that case, we will try each address in the list until a connection is |