Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 690893002: Don't use getPropertyCSSValue in treeoutline.js (Closed)

Created:
6 years, 1 month ago by Timothy Loh
Modified:
6 years, 1 month ago
Reviewers:
vsevik, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Don't use getPropertyCSSValue in treeoutline.js As the exposed interface getPropertyCSSValue is going to be removed, we shouldn't rely on it. BUG=428595 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184630

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M Source/devtools/front_end/ui/treeoutline.js View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Timothy Loh
I manually tested clicking some disclosure triangles in the DOM viewer and the sources tab.
6 years, 1 month ago (2014-10-30 06:43:43 UTC) #2
pfeldman
lgtm
6 years, 1 month ago (2014-10-30 08:57:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/690893002/1
6 years, 1 month ago (2014-10-30 09:33:25 UTC) #5
commit-bot: I haz the power
6 years, 1 month ago (2014-10-30 09:37:40 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 184630

Powered by Google App Engine
This is Rietveld 408576698