Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 690753007: Removing reloadAll() from InstallEvent (Closed)

Created:
6 years, 1 month ago by Paritosh Kumar
Modified:
6 years, 1 month ago
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Removing reloadAll() from InstallEvent As it's gone from the spec and the blink impl just throws an exception removing it. BUG=428512 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184659

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -12 lines) Patch
M Source/modules/serviceworkers/InstallEvent.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/modules/serviceworkers/InstallEvent.cpp View 1 chunk +0 lines, -9 lines 0 comments Download
M Source/modules/serviceworkers/InstallEvent.idl View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 9 (5 generated)
Paritosh Kumar
PTAL.
6 years, 1 month ago (2014-10-30 12:25:47 UTC) #5
jsbell
lgtm Since this was triaged as P-3 but still M-40 and seems harmless, I'll go ...
6 years, 1 month ago (2014-10-30 16:01:48 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/690753007/1
6 years, 1 month ago (2014-10-30 16:02:43 UTC) #8
commit-bot: I haz the power
6 years, 1 month ago (2014-10-30 17:04:49 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 184659

Powered by Google App Engine
This is Rietveld 408576698