Source/modules/serviceworkers/InstallEvent.cpp - Issue 690753007: Removing reloadAll() from InstallEvent

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/serviceworkers/InstallEvent.cpp

Issue 690753007: Removing reloadAll() from InstallEvent (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/modules/serviceworkers/InstallEvent.cpp

diff --git a/Source/modules/serviceworkers/InstallEvent.cpp b/Source/modules/serviceworkers/InstallEvent.cpp

index c418574521de37112ee3139f24fb6cd06581d1d3..e60217af47e714a6b65c48435a30ca976f6b7cbd 100644

--- a/Source/modules/serviceworkers/InstallEvent.cpp

+++ b/Source/modules/serviceworkers/InstallEvent.cpp

@@ -54,15 +54,6 @@ void InstallEvent::replace()

notImplemented();

}

-ScriptPromise InstallEvent::reloadAll(ScriptState* scriptState)

- // FIXME: implement.

- notImplemented();

- // For now this just returns a promise which is already rejected.

- return ScriptPromise::reject(scriptState, v8::Null(scriptState->isolate()));

const AtomicString& InstallEvent::interfaceName() const

{

return EventNames::InstallEvent;