Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(518)

Issue 690533004: scale xmin/xmax etc in fontmetrics (Closed)

Created:
6 years, 1 month ago by reed2
Modified:
6 years, 1 month ago
Reviewers:
bungeman-skia
CC:
reviews_skia.org, mtklein
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

scale xmin/xmax etc in fontmetrics BUG=skia: Committed: https://skia.googlesource.com/skia/+/f8c2feffd68b3262f3c039ec1bd517c5f6cc9e4c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M src/ports/SkFontHost_FreeType.cpp View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
reed2
6 years, 1 month ago (2014-10-29 01:36:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/690533004/1
6 years, 1 month ago (2014-10-29 01:36:48 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 1 month ago (2014-10-29 01:36:49 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Please ask for an LGTM from a full ...
6 years, 1 month ago (2014-10-29 07:36:54 UTC) #7
bungeman-skia
lgtm
6 years, 1 month ago (2014-10-29 14:52:13 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/690533004/1
6 years, 1 month ago (2014-10-29 14:53:15 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as f8c2feffd68b3262f3c039ec1bd517c5f6cc9e4c
6 years, 1 month ago (2014-10-29 14:53:28 UTC) #11
bungeman-skia
6 years, 1 month ago (2014-10-29 19:34:50 UTC) #12
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/686263002/ by bungeman@google.com.

The reason for reverting is: Breaking tests in Chromium, and not in a good way..

Powered by Google App Engine
This is Rietveld 408576698