Issue 6905005: [Sync] Fix bug in ExtensionUpdater introduced by r81501

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6905005: [Sync] Fix bug in ExtensionUpdater introduced by r81501 (Closed)

Created:
9 years, 8 months ago by akalin

Modified:
9 years, 7 months ago

Reviewers:
commit-bot: I haz the power, Nicolas Zea

CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, pam+watch_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

[Sync] Fix bug in ExtensionUpdater introduced by r81501 Basically, r81501 broke ExtensionUpdater::CheckSoon(), which is relied on by extension/app/theme sync. BUG=80496 TEST=Open two browser instances with theme sync enabled. Install a new theme on one browser. It should show up in the other. Repeat a few times. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=82943

Patch Set 1 #

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -5 lines)			Patch
	M	chrome/browser/extensions/extension_updater.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
	M	chrome/browser/extensions/extension_updater_unittest.cc	View		2 chunks	+5 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Change committed as 82943

Expand Messages | Collapse Messages