Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(977)

Issue 6905005: [Sync] Fix bug in ExtensionUpdater introduced by r81501 (Closed)

Created:
9 years, 8 months ago by akalin
Modified:
9 years, 7 months ago
CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, pam+watch_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

[Sync] Fix bug in ExtensionUpdater introduced by r81501 Basically, r81501 broke ExtensionUpdater::CheckSoon(), which is relied on by extension/app/theme sync. BUG=80496 TEST=Open two browser instances with theme sync enabled. Install a new theme on one browser. It should show up in the other. Repeat a few times. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=82943

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M chrome/browser/extensions/extension_updater.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_updater_unittest.cc View 2 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
akalin
+zea for review
9 years, 8 months ago (2011-04-25 21:38:16 UTC) #1
Nicolas Zea
LGTM
9 years, 8 months ago (2011-04-25 21:44:45 UTC) #2
commit-bot: I haz the power
9 years, 8 months ago (2011-04-25 23:07:54 UTC) #3
Change committed as 82943

Powered by Google App Engine
This is Rietveld 408576698