Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(852)

Unified Diff: chrome/browser/extensions/extension_updater_unittest.cc

Issue 6905005: [Sync] Fix bug in ExtensionUpdater introduced by r81501 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/extension_updater.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extension_updater_unittest.cc
diff --git a/chrome/browser/extensions/extension_updater_unittest.cc b/chrome/browser/extensions/extension_updater_unittest.cc
index 817de108dad50635549a31fd66cea8aca83102d0..aca65c45c247f22f33af879bf5aea8fa242131f0 100644
--- a/chrome/browser/extensions/extension_updater_unittest.cc
+++ b/chrome/browser/extensions/extension_updater_unittest.cc
@@ -270,9 +270,10 @@ class ExtensionUpdaterTest : public testing::Test {
updater->TimerFired();
}
- static void SimulateCheckSoon(ExtensionUpdater* updater) {
- EXPECT_TRUE(updater->will_check_soon_);
- updater->DoCheckSoon();
+ static void SimulateCheckSoon(const ExtensionUpdater& updater,
+ MessageLoop* message_loop) {
+ EXPECT_TRUE(updater.will_check_soon_);
+ message_loop->RunAllPending();
}
// Adds a Result with the given data to results.
@@ -1133,7 +1134,7 @@ TEST(ExtensionUpdaterTest, TestCheckSoon) {
EXPECT_TRUE(updater.WillCheckSoon());
updater.CheckSoon();
EXPECT_TRUE(updater.WillCheckSoon());
- ExtensionUpdaterTest::SimulateCheckSoon(&updater);
+ ExtensionUpdaterTest::SimulateCheckSoon(updater, &message_loop);
EXPECT_FALSE(updater.WillCheckSoon());
updater.CheckSoon();
EXPECT_TRUE(updater.WillCheckSoon());
« no previous file with comments | « chrome/browser/extensions/extension_updater.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698