Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(599)

Issue 690493002: cc: Add an integration test for what scale we draw with after pinching (Closed)

Created:
6 years, 1 month ago by danakj
Modified:
6 years, 1 month ago
Reviewers:
vmpstr
CC:
chromium-reviews, cc-bugs_chromium.org, enne (OOO), piman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

cc: Add an integration test for what scale we draw with after pinching This is a LayerTreeTest that does: 1) Pinch in and end the pinch 2) Wait to draw fully at the new scale (2.2x) 3) Pinch out but hold onto the pinch 4) Wait to draw fully at the new scale (1.1x) 5) Prevent new tiles from being ready 6) End the pinch 7) Let one draw happen, which will let the raster scale change (still at 1.1x) 8) Let tiles become ready 9) Ensure we draw tiles with the ideal scale Step 9 wasn't happening for the bug this is testing. R=vmpstr BUG=427423

Patch Set 1 #

Total comments: 1

Patch Set 2 : pinchblurmerge-test: compile #

Unified diffs Side-by-side diffs Delta from patch set Stats (+179 lines, -10 lines) Patch
M cc/test/fake_content_layer_client.cc View 1 chunk +7 lines, -9 lines 0 comments Download
M cc/test/layer_tree_test.h View 1 chunk +2 lines, -0 lines 0 comments Download
M cc/test/layer_tree_test.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M cc/test/test_web_graphics_context_3d.h View 2 chunks +6 lines, -0 lines 0 comments Download
M cc/test/test_web_graphics_context_3d.cc View 2 chunks +2 lines, -1 line 0 comments Download
M cc/trees/layer_tree_host_unittest.cc View 1 2 chunks +157 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
danakj
https://codereview.chromium.org/690493002/diff/1/cc/test/fake_content_layer_client.cc File cc/test/fake_content_layer_client.cc (right): https://codereview.chromium.org/690493002/diff/1/cc/test/fake_content_layer_client.cc#newcode45 cc/test/fake_content_layer_client.cc:45: bool red = true; This makes every tile !solidcolor
6 years, 1 month ago (2014-10-28 21:14:07 UTC) #1
danakj
This test seems to expose this cc weakptr bug more. jbroman@ claims to have seen ...
6 years, 1 month ago (2014-10-29 14:36:51 UTC) #2
danakj
6 years, 1 month ago (2014-10-29 19:28:21 UTC) #3
I'm going to close this and add the test with the "real fix" to the bug.

Powered by Google App Engine
This is Rietveld 408576698