Don't warn on missing prop synthesis in non-chromium code for iOS.

Don't warn on missing prop synthesis in non-chromium code for iOS.

Certain internal directories fire many many warnings for
-Wobjc-missing-property-synthesis.

BUG=None
TEST=None

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=234543

[justincohen, 2013-11-12 00:14:54]

PTAl!

[Nico, 2013-11-12 00:25:08]

As always, please answer "why?" in the CL description. Especially for the plugin
part, which I think we do want to run for some non-chromium_code code (e.g.
skia). The plugin contains a blacklist of directories for third-party code. (If
that's too slow for you, maybe it's possible to set clang_use_chrome_plugins to
0 for the target that's having issues? not sure though.)

For the prop synthesis, there's already a large block of
chromium_code==0-dependent settings, can you move this to there?

[justincohen, 2013-11-12 02:46:34]

I reduced the CL to just
'CLANG_WARN_OBJC_MISSING_PROPERTY_SYNTHESIS': 'NO',

PTAL!

[Nico, 2013-11-12 04:29:27]

lgtm

https://codereview.chromium.org/69033005/diff/60001/build/common.gypi
File build/common.gypi (right):

https://codereview.chromium.org/69033005/diff/60001/build/common.gypi#newcode...
build/common.gypi:2488: 'CLANG_WARN_OBJC_MISSING_PROPERTY_SYNTHESIS': 'NO',
Maybe add a comment above this line saying what it's for too.

[justincohen, 2013-11-12 12:44:46]

https://codereview.chromium.org/69033005/diff/60001/build/common.gypi
File build/common.gypi (right):

https://codereview.chromium.org/69033005/diff/60001/build/common.gypi#newcode...
build/common.gypi:2488: 'CLANG_WARN_OBJC_MISSING_PROPERTY_SYNTHESIS': 'NO',
On 2013/11/12 04:29:27, Nico wrote:
> Maybe add a comment above this line saying what it's for too.

Done.

[commit-bot: I haz the power, 2013-11-12 12:49:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/justincohen@chromium.org/69033005/110001

[stuartmorgan1, 2013-11-12 15:31:43]

lgtm

[commit-bot: I haz the power, 2013-11-12 17:01:21]

Change committed as 234543