Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Side by Side Diff: build/common.gypi

Issue 69033005: Don't warn on missing prop synthesis in non-chromium code for iOS. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Address Nico Comments Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # IMPORTANT: 5 # IMPORTANT:
6 # Please don't directly include this file if you are building via gyp_chromium, 6 # Please don't directly include this file if you are building via gyp_chromium,
7 # since gyp_chromium is automatically forcing its inclusion. 7 # since gyp_chromium is automatically forcing its inclusion.
8 { 8 {
9 # Variables expected to be overriden on the GYP command line (-D) or by 9 # Variables expected to be overriden on the GYP command line (-D) or by
10 # ~/.gyp/include.gypi. 10 # ~/.gyp/include.gypi.
(...skipping 2467 matching lines...) Expand 10 before | Expand all | Expand 10 after
2478 }], 2478 }],
2479 ], 2479 ],
2480 }], 2480 }],
2481 [ 'OS=="ios"', { 2481 [ 'OS=="ios"', {
2482 'xcode_settings': { 2482 'xcode_settings': {
2483 # TODO(ios): Fix remaining warnings in third-party code, then 2483 # TODO(ios): Fix remaining warnings in third-party code, then
2484 # remove this; the Mac cleanup didn't get everything that's 2484 # remove this; the Mac cleanup didn't get everything that's
2485 # flagged in an iOS build. 2485 # flagged in an iOS build.
2486 'GCC_TREAT_WARNINGS_AS_ERRORS': 'NO', 2486 'GCC_TREAT_WARNINGS_AS_ERRORS': 'NO',
2487 'RUN_CLANG_STATIC_ANALYZER': 'NO', 2487 'RUN_CLANG_STATIC_ANALYZER': 'NO',
2488 'CLANG_WARN_OBJC_MISSING_PROPERTY_SYNTHESIS': 'NO',
Nico 2013/11/12 04:29:27 Maybe add a comment above this line saying what it
justincohen 2013/11/12 12:44:46 Done.
2488 }, 2489 },
2489 }], 2490 }],
2490 ], 2491 ],
2491 }, { 2492 }, {
2492 'includes': [ 2493 'includes': [
2493 # Rules for excluding e.g. foo_win.cc from the build on non-Windows. 2494 # Rules for excluding e.g. foo_win.cc from the build on non-Windows.
2494 'filename_rules.gypi', 2495 'filename_rules.gypi',
2495 ], 2496 ],
2496 # In Chromium code, we define __STDC_foo_MACROS in order to get the 2497 # In Chromium code, we define __STDC_foo_MACROS in order to get the
2497 # C99 macros on Mac and Linux. 2498 # C99 macros on Mac and Linux.
(...skipping 2202 matching lines...) Expand 10 before | Expand all | Expand 10 after
4700 # settings in target dicts. SYMROOT is a special case, because many other 4701 # settings in target dicts. SYMROOT is a special case, because many other
4701 # Xcode variables depend on it, including variables such as 4702 # Xcode variables depend on it, including variables such as
4702 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something 4703 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something
4703 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the 4704 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the
4704 # files to appear (when present) in the UI as actual files and not red 4705 # files to appear (when present) in the UI as actual files and not red
4705 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR, 4706 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR,
4706 # and therefore SYMROOT, needs to be set at the project level. 4707 # and therefore SYMROOT, needs to be set at the project level.
4707 'SYMROOT': '<(DEPTH)/xcodebuild', 4708 'SYMROOT': '<(DEPTH)/xcodebuild',
4708 }, 4709 },
4709 } 4710 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698