Issue 690263004: Introduce new stepping mode to step into another frame.

Issue 690263004: Introduce new stepping mode to step into another frame. (Closed)

Created:
6 years, 1 month ago by Yang

Modified:
6 years, 1 month ago

Reviewers:
aandrey

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

Introduce new stepping mode to step into another frame. R=aandrey@chromium.org BUG=chromium:267592 LOG=Y Committed: https://code.google.com/p/v8/source/detail?r=25130

Patch Set 2 : fix test case and fix throw-catch handling #

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+195 lines, -63 lines)			Patch
M	src/debug.h	View		5 chunks	+16 lines, -15 lines	0 comments	Download
M	src/debug.cc	View	1	14 chunks	+61 lines, -40 lines	0 comments	Download
M	src/debug-debugger.js	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	src/objects.cc	View		2 chunks	+4 lines, -6 lines	0 comments	Download
M	src/runtime/runtime-debug.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
A	test/mjsunit/debug-stepframe.js	View	1	1 chunk	+111 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

aandrey

Very nice! LGTM https://codereview.chromium.org/690263004/diff/1/test/mjsunit/debug-stepframe.js File test/mjsunit/debug-stepframe.js (right): https://codereview.chromium.org/690263004/diff/1/test/mjsunit/debug-stepframe.js#newcode14 test/mjsunit/debug-stepframe.js:14: f1(); // Break 3 remove comment? ...

6 years, 1 month ago (2014-11-04 17:28:18 UTC) #2

Yang

https://codereview.chromium.org/690263004/diff/1/test/mjsunit/debug-stepframe.js File test/mjsunit/debug-stepframe.js (right): https://codereview.chromium.org/690263004/diff/1/test/mjsunit/debug-stepframe.js#newcode14 test/mjsunit/debug-stepframe.js:14: f1(); // Break 3 On 2014/11/04 17:28:18, aandrey wrote: ...

6 years, 1 month ago (2014-11-04 17:30:13 UTC) #3

Yang

Committed patchset #2 (id:20001) manually as 25130 (presubmit successful).

6 years, 1 month ago (2014-11-05 08:44:41 UTC) #4

Message was sent while issue was closed.

still lgtm

Expand Messages | Collapse Messages