Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Side by Side Diff: src/runtime/runtime-debug.cc

Issue 690263004: Introduce new stepping mode to step into another frame. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: fix test case and fix throw-catch handling Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/objects.cc ('k') | test/mjsunit/debug-stepframe.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #include "src/accessors.h" 7 #include "src/accessors.h"
8 #include "src/arguments.h" 8 #include "src/arguments.h"
9 #include "src/debug.h" 9 #include "src/debug.h"
10 #include "src/deoptimizer.h" 10 #include "src/deoptimizer.h"
(...skipping 1966 matching lines...) Expand 10 before | Expand all | Expand 10 after
1977 if (wrapped_frame_id == 0) { 1977 if (wrapped_frame_id == 0) {
1978 frame_id = StackFrame::NO_ID; 1978 frame_id = StackFrame::NO_ID;
1979 } else { 1979 } else {
1980 frame_id = UnwrapFrameId(wrapped_frame_id); 1980 frame_id = UnwrapFrameId(wrapped_frame_id);
1981 } 1981 }
1982 1982
1983 // Get the step action and check validity. 1983 // Get the step action and check validity.
1984 StepAction step_action = static_cast<StepAction>(NumberToInt32(args[1])); 1984 StepAction step_action = static_cast<StepAction>(NumberToInt32(args[1]));
1985 if (step_action != StepIn && step_action != StepNext && 1985 if (step_action != StepIn && step_action != StepNext &&
1986 step_action != StepOut && step_action != StepInMin && 1986 step_action != StepOut && step_action != StepInMin &&
1987 step_action != StepMin) { 1987 step_action != StepMin && step_action != StepFrame) {
1988 return isolate->Throw(isolate->heap()->illegal_argument_string()); 1988 return isolate->Throw(isolate->heap()->illegal_argument_string());
1989 } 1989 }
1990 1990
1991 if (frame_id != StackFrame::NO_ID && step_action != StepNext && 1991 if (frame_id != StackFrame::NO_ID && step_action != StepNext &&
1992 step_action != StepMin && step_action != StepOut) { 1992 step_action != StepMin && step_action != StepOut) {
1993 return isolate->ThrowIllegalOperation(); 1993 return isolate->ThrowIllegalOperation();
1994 } 1994 }
1995 1995
1996 // Get the number of steps. 1996 // Get the number of steps.
1997 int step_count = NumberToInt32(args[2]); 1997 int step_count = NumberToInt32(args[2]);
(...skipping 723 matching lines...) Expand 10 before | Expand all | Expand 10 after
2721 return Smi::FromInt(isolate->debug()->is_active()); 2721 return Smi::FromInt(isolate->debug()->is_active());
2722 } 2722 }
2723 2723
2724 2724
2725 RUNTIME_FUNCTION(RuntimeReference_DebugBreakInOptimizedCode) { 2725 RUNTIME_FUNCTION(RuntimeReference_DebugBreakInOptimizedCode) {
2726 UNIMPLEMENTED(); 2726 UNIMPLEMENTED();
2727 return NULL; 2727 return NULL;
2728 } 2728 }
2729 } 2729 }
2730 } // namespace v8::internal 2730 } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/objects.cc ('k') | test/mjsunit/debug-stepframe.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698