Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 6902107: Merge 82987, 83304 - make sure that OEM tab is shown even if first login is Guest (Closed)

Created:
9 years, 8 months ago by Dmitry Polukhin
Modified:
9 years, 7 months ago
Reviewers:
oritm, Nikita (slow), zel
CC:
chromium-reviews, nkostylev+cc_chromium.org, rharrison, Erik does not do reviews, Aaron Boodman, pam+watch_chromium.org, Paweł Hajdan Jr., davemoore+watch_chromium.org
Visibility:
Public.

Description

Merge 82987, 83304 - make sure that OEM tab is shown even if first login is Guest Merge 82987 - HWID and VPD values should be accessible via SystemAccess::GetMachineStatistic BUG=chromium-os:13019 TEST=NameValuePairsParser.* StartupCustomizationDocumentTest.* Review URL: http://codereview.chromium.org/6899021 Merge 83304 - Make customization documents singletons. BUG=chromium-os:13019 TEST=existing browser tests Review URL: http://codereview.chromium.org/6893052 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=83358

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+457 lines, -927 lines) Patch
M chrome/browser/chromeos/customization_document.h View 4 chunks +92 lines, -18 lines 0 comments Download
M chrome/browser/chromeos/customization_document.cc View 5 chunks +153 lines, -83 lines 0 comments Download
M chrome/browser/chromeos/customization_document_unittest.cc View 2 chunks +71 lines, -73 lines 0 comments Download
D chrome/browser/chromeos/login/apply_services_customization.h View 1 chunk +0 lines, -81 lines 0 comments Download
D chrome/browser/chromeos/login/apply_services_customization.cc View 1 chunk +0 lines, -174 lines 0 comments Download
M chrome/browser/chromeos/login/base_login_display_host.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/base_login_display_host.cc View 5 chunks +8 lines, -9 lines 0 comments Download
M chrome/browser/chromeos/login/eula_view.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/existing_user_controller.h View 2 chunks +0 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/login/existing_user_controller.cc View 4 chunks +12 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/login/existing_user_controller_browsertest.cc View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/chromeos/login/helper.h View 2 chunks +0 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/login/helper.cc View 3 chunks +1 line, -26 lines 0 comments Download
M chrome/browser/chromeos/login/login_display_host.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/wizard_controller.h View 3 chunks +0 lines, -12 lines 0 comments Download
M chrome/browser/chromeos/login/wizard_controller.cc View 6 chunks +5 lines, -33 lines 0 comments Download
A + chrome/browser/chromeos/mock_system_access.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/chromeos/name_value_pairs_parser.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/chromeos/name_value_pairs_parser.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/chromeos/name_value_pairs_parser_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/browser/chromeos/system_access.h View 2 chunks +11 lines, -60 lines 0 comments Download
M chrome/browser/chromeos/system_access.cc View 6 chunks +70 lines, -109 lines 0 comments Download
D chrome/browser/chromeos/system_access_unittest.cc View 1 chunk +0 lines, -54 lines 0 comments Download
M chrome/browser/extensions/extension_info_private_api_chromeos.h View 2 chunks +1 line, -17 lines 0 comments Download
M chrome/browser/extensions/extension_info_private_api_chromeos.cc View 3 chunks +23 lines, -148 lines 0 comments Download
M chrome/browser/prefs/browser_prefs.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/register_page_ui.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/chrome_browser.gypi View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/chrome_tests.gypi View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Dmitry Polukhin
This merge is really large so there is some potential risk merging it into 742 ...
9 years, 8 months ago (2011-04-28 08:21:24 UTC) #1
Nikita (slow)
9 years, 8 months ago (2011-04-28 09:38:50 UTC) #2 
I think we still should merge it as this refactoring is pretty straightforward
and my carrier specific changes are build on top of this change (using singleton
manifests).

Powered by Google App Engine
This is Rietveld 408576698