Issue 6899021: HWID and VPD values should be accessible via SystemAccess::GetMachineStatistic

Issue 6899021: HWID and VPD values should be accessible via SystemAccess::GetMachineStatistic (Closed)

Created:
9 years, 8 months ago by Dmitry Polukhin

Modified:
9 years, 7 months ago

Reviewers:
petkov, stevenjb, zel, altimofeev

CC:
chromium-reviews, nkostylev+cc_chromium.org, Erik does not do reviews, Aaron Boodman, pam+watch_chromium.org, Paweł Hajdan Jr., davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

HWID and VPD values should be accessible via SystemAccess::GetMachineStatistic BUG=chromium-os:13019 TEST=NameValuePairsParser.* StartupCustomizationDocumentTest.* Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=82987

Patch Set 1 #

Patch Set 2 : update header #

Patch Set 3 : nit #

Patch Set 4 : fixed ExtensionApiTest.CustomizationPrivateTest #

Patch Set 5 : move ChromeosInfo to UI thread only #

Total comments: 6

Patch Set 6 : comments resolved #

Patch Set 7 : unit_test #

Total comments: 1

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+426 lines, -527 lines)			Patch
M	chrome/browser/chromeos/customization_document.h	View	1 2	3 chunks	+6 lines, -13 lines	0 comments	Download
M	chrome/browser/chromeos/customization_document.cc	View	1 2	6 chunks	+18 lines, -82 lines	0 comments	Download
M	chrome/browser/chromeos/customization_document_unittest.cc	View	1	2 chunks	+72 lines, -74 lines	0 comments	Download
M	chrome/browser/chromeos/login/helper.cc	View		2 chunks	+3 lines, -1 line	0 comments	Download
A	chrome/browser/chromeos/mock_system_access.h	View		1 chunk	+31 lines, -0 lines	0 comments	Download
A	chrome/browser/chromeos/name_value_pairs_parser.h	View	1 2 3 4 5	1 chunk	+52 lines, -0 lines	0 comments	Download
A	chrome/browser/chromeos/name_value_pairs_parser.cc	View	1 2 3 4 5	1 chunk	+103 lines, -0 lines	0 comments	Download
A +	chrome/browser/chromeos/name_value_pairs_parser_unittest.cc	View	1 2 3 4 5 6	1 chunk	+31 lines, -21 lines	0 comments	Download
M	chrome/browser/chromeos/system_access.h	View		2 chunks	+11 lines, -60 lines	0 comments	Download
M	chrome/browser/chromeos/system_access.cc	View	1 2 3 4 5	6 chunks	+70 lines, -109 lines	1 comment	Download
M	chrome/browser/extensions/extension_info_private_api_chromeos.h	View	1 2 3 4	2 chunks	+1 line, -17 lines	0 comments	Download
M	chrome/browser/extensions/extension_info_private_api_chromeos.cc	View	1 2 3 4 5	3 chunks	+23 lines, -148 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	1 2 3 4	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View	1 2 3 4	2 chunks	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 11 (0 generated)

Expand Messages | Collapse Messages

Dmitry Polukhin

Steven, I need your review as cros owner. Alexey from GetChromeosInfoFunction point of view.

9 years, 8 months ago (2011-04-25 09:14:14 UTC) #2

altimofeev

Dima, please also get rid of the FILE thread and caching in GetChromeosInfoPrivate (as we ...

9 years, 8 months ago (2011-04-25 10:34:30 UTC) #3

Dmitry Polukhin

On 2011/04/25 10:34:30, altimofeev wrote: > Dima, please also get rid of the FILE thread ...

9 years, 8 months ago (2011-04-25 13:51:32 UTC) #4

stevenjb

http://codereview.chromium.org/6899021/diff/3014/chrome/browser/chromeos/name_value_pairs_parser.cc File chrome/browser/chromeos/name_value_pairs_parser.cc (right): http://codereview.chromium.org/6899021/diff/3014/chrome/browser/chromeos/name_value_pairs_parser.cc#newcode18 chrome/browser/chromeos/name_value_pairs_parser.cc:18: const char kQuotaChars[] = "\""; s/kQuotaChars/kQuoteChars http://codereview.chromium.org/6899021/diff/3014/chrome/browser/chromeos/name_value_pairs_parser.h File chrome/browser/chromeos/name_value_pairs_parser.h ...

9 years, 8 months ago (2011-04-25 17:07:33 UTC) #6

Dmitry Polukhin

9 years, 8 months ago (2011-04-25 18:50:00 UTC) #7

Dmitry Polukhin

Steven, I'm going to commit this CL because your comments were about names and I ...

9 years, 8 months ago (2011-04-26 04:36:49 UTC) #8

stevenjb

Sorry, I somehow didn't get an email when this was updated. LGTM

9 years, 8 months ago (2011-04-28 16:44:55 UTC) #10

petkov

9 years, 7 months ago (2011-05-18 22:31:24 UTC) #11

http://codereview.chromium.org/6899021/diff/10001/chrome/browser/chromeos/sys...
File chrome/browser/chromeos/system_access.cc (right):

http://codereview.chromium.org/6899021/diff/10001/chrome/browser/chromeos/sys...
chrome/browser/chromeos/system_access.cc:45: const char kHwidKey[] = "hwid";
this is equivalent of hardware_class above.

also, this needs to be switched to use
"crossystem hwid" so that it works on both x86 and arm

Expand Messages | Collapse Messages