Issue 690153002: [Sync] Fix bug where DeviceInfo is missing a backup timestamp

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 690153002: [Sync] Fix bug where DeviceInfo is missing a backup timestamp (Closed)

Created:
6 years, 1 month ago by maniscalco

Modified:
6 years, 1 month ago

Reviewers:

CC:
chromium-reviews, tim+watch_chromium.org, pvalenzuela+watch_chromium.org, haitaol+watch_chromium.org, zea+watch_chromium.org, maniscalco+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@2171

Project:
chromium

Visibility:
Public.

More Reviews

Description

[Sync] Fix bug where DeviceInfo is missing a backup timestamp Remove last_synced_time_ member variable from ProfileSyncService. This variable acted as a cache of the underlying pref. However, it was not properly cleared in ProfileSyncService::DisableForUser when the associated pref was cleared. This caused a bug where device info may not have a backup timestamp. BUG=427096 Review URL: https://codereview.chromium.org/660023003 Cr-Commit-Position: refs/heads/master@{#301481} (cherry picked from commit 44d307099fc662e56b57c59f23214a85c2b206b2) Committed: https://chromium.googlesource.com/chromium/src/+/7245a543f356484c05869f4924d1f5caa3bbff3b

Patch Set 1 #

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+34 lines, -17 lines)			Patch
M	chrome/browser/sync/profile_sync_service.h	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	chrome/browser/sync/profile_sync_service.cc	View	5 chunks	+13 lines, -13 lines	0 comments	Download
M	chrome/browser/sync/profile_sync_service_unittest.cc	View	3 chunks	+21 lines, -0 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

maniscalco

6 years, 1 month ago (2014-10-30 22:40:53 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
7245a543f356484c05869f4924d1f5caa3bbff3b.

Expand Messages | Collapse Messages