Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Issue 660023003: [Sync] Fix bug where DeviceInfo is missing a backup timestamp (Closed)

Created:
6 years, 2 months ago by maniscalco
Modified:
6 years, 1 month ago
Reviewers:
Nicolas Zea
CC:
chromium-reviews, tim+watch_chromium.org, pvalenzuela+watch_chromium.org, zea+watch_chromium.org, maniscalco+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Sync] Fix bug where DeviceInfo is missing a backup timestamp Remove last_synced_time_ member variable from ProfileSyncService. This variable acted as a cache of the underlying pref. However, it was not properly cleared in ProfileSyncService::DisableForUser when the associated pref was cleared. This caused a bug where device info may not have a backup timestamp. BUG=427096 Committed: https://crrev.com/44d307099fc662e56b57c59f23214a85c2b206b2 Cr-Commit-Position: refs/heads/master@{#301481}

Patch Set 1 #

Patch Set 2 : Add unit test that verifies fix. #

Patch Set 3 : Merge with master. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -17 lines) Patch
M chrome/browser/sync/profile_sync_service.h View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/sync/profile_sync_service.cc View 1 2 5 chunks +13 lines, -13 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_unittest.cc View 1 3 chunks +21 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
maniscalco
Nicolas, would you please review this change?
6 years, 1 month ago (2014-10-27 19:05:51 UTC) #2
Nicolas Zea
LGTM!
6 years, 1 month ago (2014-10-27 19:07:50 UTC) #3
maniscalco
On 2014/10/27 19:07:50, Nicolas Zea wrote: > LGTM! Thanks for the speedy review!
6 years, 1 month ago (2014-10-27 21:32:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/660023003/40001
6 years, 1 month ago (2014-10-27 21:34:18 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years, 1 month ago (2014-10-27 23:34:17 UTC) #7
commit-bot: I haz the power
6 years, 1 month ago (2014-10-27 23:34:59 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/44d307099fc662e56b57c59f23214a85c2b206b2
Cr-Commit-Position: refs/heads/master@{#301481}

Powered by Google App Engine
This is Rietveld 408576698