Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 690123002: Switch to using TintedImageButton where possible. (Closed)

Created:
6 years, 1 month ago by aurimas (slooooooooow)
Modified:
6 years, 1 month ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Switch to using TintedImageButton where possible. BUG=427719 R=dtrainor@chromium.org Committed: https://crrev.com/cf09bfbca9ce0280aa31f3c93564bc29031580d7 Cr-Commit-Position: refs/heads/master@{#302680}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -115 lines) Patch
A + chrome/android/java/res/color/button_tint_menu.xml View 1 chunk +1 line, -5 lines 0 comments Download
A chrome/android/java/res/color/button_tint_white.xml View 1 chunk +12 lines, -0 lines 0 comments Download
M chrome/android/java/res/color/default_button_tint.xml View 1 chunk +6 lines, -6 lines 0 comments Download
A chrome/android/java/res/drawable-hdpi/btn_back.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-hdpi/btn_back_disabled.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-hdpi/btn_back_normal.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-hdpi/btn_back_pressed.png View Binary file 0 comments Download
A chrome/android/java/res/drawable-hdpi/btn_forward.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-hdpi/btn_forward_disabled.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-hdpi/btn_forward_normal.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-hdpi/btn_forward_pressed.png View Binary file 0 comments Download
A + chrome/android/java/res/drawable-hdpi/btn_menu.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-hdpi/btn_menu_disabled.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-hdpi/btn_menu_normal.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-hdpi/btn_menu_pressed.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-hdpi/btn_menu_white_normal.png View Binary file 0 comments Download
A chrome/android/java/res/drawable-ldrtl-hdpi/btn_back.png View Binary file 0 comments Download
A chrome/android/java/res/drawable-ldrtl-hdpi/btn_forward.png View Binary file 0 comments Download
A chrome/android/java/res/drawable-ldrtl-mdpi/btn_back.png View Binary file 0 comments Download
A chrome/android/java/res/drawable-ldrtl-mdpi/btn_forward.png View Binary file 0 comments Download
A chrome/android/java/res/drawable-ldrtl-xhdpi/btn_back.png View Binary file 0 comments Download
A chrome/android/java/res/drawable-ldrtl-xhdpi/btn_forward.png View Binary file 0 comments Download
A chrome/android/java/res/drawable-ldrtl-xxhdpi/btn_back.png View Binary file 0 comments Download
A chrome/android/java/res/drawable-ldrtl-xxhdpi/btn_forward.png View Binary file 0 comments Download
A chrome/android/java/res/drawable-ldrtl-xxxhdpi/btn_back.png View Binary file 0 comments Download
A chrome/android/java/res/drawable-ldrtl-xxxhdpi/btn_forward.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-ldrtl/btn_back.xml View 1 chunk +0 lines, -15 lines 0 comments Download
D chrome/android/java/res/drawable-ldrtl/btn_forward.xml View 1 chunk +0 lines, -15 lines 0 comments Download
A chrome/android/java/res/drawable-mdpi/btn_back.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-mdpi/btn_back_disabled.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-mdpi/btn_back_normal.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-mdpi/btn_back_pressed.png View Binary file 0 comments Download
A chrome/android/java/res/drawable-mdpi/btn_forward.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-mdpi/btn_forward_disabled.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-mdpi/btn_forward_normal.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-mdpi/btn_forward_pressed.png View Binary file 0 comments Download
A + chrome/android/java/res/drawable-mdpi/btn_menu.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-mdpi/btn_menu_disabled.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-mdpi/btn_menu_normal.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-mdpi/btn_menu_pressed.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-mdpi/btn_menu_white_normal.png View Binary file 0 comments Download
A chrome/android/java/res/drawable-xhdpi/btn_back.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-xhdpi/btn_back_disabled.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-xhdpi/btn_back_normal.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-xhdpi/btn_back_pressed.png View Binary file 0 comments Download
A chrome/android/java/res/drawable-xhdpi/btn_forward.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-xhdpi/btn_forward_disabled.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-xhdpi/btn_forward_normal.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-xhdpi/btn_forward_pressed.png View Binary file 0 comments Download
A + chrome/android/java/res/drawable-xhdpi/btn_menu.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-xhdpi/btn_menu_disabled.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-xhdpi/btn_menu_normal.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-xhdpi/btn_menu_pressed.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-xhdpi/btn_menu_white_normal.png View Binary file 0 comments Download
A chrome/android/java/res/drawable-xxhdpi/btn_back.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-xxhdpi/btn_back_disabled.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-xxhdpi/btn_back_normal.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-xxhdpi/btn_back_pressed.png View Binary file 0 comments Download
A chrome/android/java/res/drawable-xxhdpi/btn_forward.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-xxhdpi/btn_forward_disabled.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-xxhdpi/btn_forward_normal.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-xxhdpi/btn_forward_pressed.png View Binary file 0 comments Download
A + chrome/android/java/res/drawable-xxhdpi/btn_menu.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-xxhdpi/btn_menu_disabled.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-xxhdpi/btn_menu_normal.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-xxhdpi/btn_menu_pressed.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-xxhdpi/btn_menu_white_normal.png View Binary file 0 comments Download
A chrome/android/java/res/drawable-xxxhdpi/btn_back.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-xxxhdpi/btn_back_disabled.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-xxxhdpi/btn_back_normal.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-xxxhdpi/btn_back_pressed.png View Binary file 0 comments Download
A chrome/android/java/res/drawable-xxxhdpi/btn_forward.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-xxxhdpi/btn_forward_disabled.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-xxxhdpi/btn_forward_normal.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-xxxhdpi/btn_forward_pressed.png View Binary file 0 comments Download
A + chrome/android/java/res/drawable-xxxhdpi/btn_menu.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-xxxhdpi/btn_menu_disabled.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-xxxhdpi/btn_menu_normal.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-xxxhdpi/btn_menu_pressed.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-xxxhdpi/btn_menu_white_normal.png View Binary file 0 comments Download
D chrome/android/java/res/drawable/btn_back.xml View 1 chunk +0 lines, -15 lines 0 comments Download
D chrome/android/java/res/drawable/btn_forward.xml View 1 chunk +0 lines, -15 lines 0 comments Download
D chrome/android/java/res/drawable/btn_menu.xml View 1 chunk +0 lines, -15 lines 0 comments Download
M chrome/android/java/res/layout/four_button_menu_item.xml View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/android/java/res/layout/three_button_menu_item.xml View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/android/java/res/layout/title_button_menu_item.xml View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/res/layout/two_button_menu_item.xml View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/android/java/res/values/colors.xml View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuAdapter.java View 7 chunks +27 lines, -16 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/widget/TintedImageButton.java View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/android/shell/res/layout/chrome_shell_activity.xml View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
aurimas (slooooooooow)
dtrainor: PTAL
6 years, 1 month ago (2014-10-30 22:24:12 UTC) #2
David Trainor- moved to gerrit
This is really awesome! Are there any downstream usages of these assets? I think tablets ...
6 years, 1 month ago (2014-10-30 23:54:42 UTC) #3
aurimas (slooooooooow)
Committed patchset #1 (id:1) manually as cf09bfbca9ce0280aa31f3c93564bc29031580d7 (presubmit successful).
6 years, 1 month ago (2014-11-04 22:27:38 UTC) #4
commit-bot: I haz the power
6 years, 1 month ago (2014-11-04 22:27:39 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cf09bfbca9ce0280aa31f3c93564bc29031580d7
Cr-Commit-Position: refs/heads/master@{#302680}

Powered by Google App Engine
This is Rietveld 408576698