chrome/android/java/src/org/chromium/chrome/browser/widget/TintedImageButton.java - Issue 690123002: Switch to using TintedImageButton where possible.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/widget/TintedImageButton.java

Issue 690123002: Switch to using TintedImageButton where possible. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuAdapter.java ('k') | chrome/android/shell/res/layout/chrome_shell_activity.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/widget/TintedImageButton.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/widget/TintedImageButton.java b/chrome/android/java/src/org/chromium/chrome/browser/widget/TintedImageButton.java

index 4a46a39efdffb697a098303cbf3e646fb4c3a01d..72faebc8a2c28ae3af5d3c4e66295850dfadb59f 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/widget/TintedImageButton.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/widget/TintedImageButton.java

@@ -68,7 +68,6 @@ public class TintedImageButton extends ImageButton {

private void setTintInternal(ColorStateList tint) {

if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.LOLLIPOP) {

setImageTintList(tint);

- setImageTintMode(PorterDuff.Mode.SRC_ATOP);

} else {

mTint = tint;

}

@@ -76,6 +75,6 @@ public class TintedImageButton extends ImageButton {

private void updateTintColor() {

if (mTint == null || !mTint.isStateful()) return;

- setColorFilter(mTint.getColorForState(getDrawableState(), 0));

+ setColorFilter(mTint.getColorForState(getDrawableState(), 0), PorterDuff.Mode.SRC_IN);

}