Use new APIs in base/values.h: Value::GetAsNumber and DictionaryValue::GetNumber.

Remove Value::GetAsInteger() calls.

Since r83705, Value::GetAsDouble() can return an integer value as double. We no longer need to call Value::GetAsInteger() explicitly.

BUG=None
TEST=ran try

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=84263

[Mihai Parparita -not on Chrome, 2011-04-28 19:35:39]

Looks like this can be used in a few more places:

http://www.google.com/codesearch/p?hl=en#OAMlx_jo-ck/src/chrome/test/webdrive...

http://www.google.com/codesearch/p?hl=en#OAMlx_jo-ck/src/content/browser/host...

http://www.google.com/codesearch/p?hl=en#OAMlx_jo-ck/src/chrome/common/extens...

http://www.google.com/codesearch/p?hl=en#OAMlx_jo-ck/src/chrome/browser/autom...

http://www.google.com/codesearch/p?hl=en#OAMlx_jo-ck/src/chrome/browser/print...

[Yusuke Sato, 2011-05-02 12:46:39]

Done. Fixed chrome/browser/themes/browser_theme_pack.cc as well.

jam:
Could you review content/browser/host_zoom_map.cc?

Thanks,
Yusuke

On 2011/04/28 19:35:39, Mihai Parparita wrote:
> Looks like this can be used in a few more places:
> 
>
http://www.google.com/codesearch/p?hl=en#OAMlx_jo-ck/src/chrome/test/webdrive...
> 
>
http://www.google.com/codesearch/p?hl=en#OAMlx_jo-ck/src/content/browser/host...
> 
>
http://www.google.com/codesearch/p?hl=en#OAMlx_jo-ck/src/chrome/common/extens...
> 
>
http://www.google.com/codesearch/p?hl=en#OAMlx_jo-ck/src/chrome/browser/autom...
> 
>
http://www.google.com/codesearch/p?hl=en#OAMlx_jo-ck/src/chrome/browser/print...

[jam, 2011-05-02 16:17:04]

http://codereview.chromium.org/6901084/diff/5001/content/browser/host_zoom_ma...
File content/browser/host_zoom_map.cc (right):

http://codereview.chromium.org/6901084/diff/5001/content/browser/host_zoom_ma...
content/browser/host_zoom_map.cc:82: success =
host_zoom_dictionary->GetDoubleWithoutPathExpansion(
why not only call GetDoubleWithoutPathExpansion?  for the old-profile code, it
will do the casting internally.

we can also get rid of the code from line 75-82, since that was just needed for
converting old profiles.  this new way of storing zoom values has been like this
for several releases already, so I don't think we need to convert anymore.

[Mihai Parparita -not on Chrome, 2011-05-02 16:59:49]

http://codereview.chromium.org/6901084/diff/5001/chrome/browser/themes/browse...
File chrome/browser/themes/browser_theme_pack.cc (right):

http://codereview.chromium.org/6901084/diff/5001/chrome/browser/themes/browse...
chrome/browser/themes/browser_theme_pack.cc:302: bool
ValidDoubleValue(ListValue* tint_list, int index, double* out) {
I think you can delete this now.

[Yusuke Sato, 2011-05-04 14:10:10]

Fixed. Please take another look.

http://codereview.chromium.org/6901084/diff/5001/chrome/browser/themes/browse...
File chrome/browser/themes/browser_theme_pack.cc (right):

http://codereview.chromium.org/6901084/diff/5001/chrome/browser/themes/browse...
chrome/browser/themes/browser_theme_pack.cc:302: bool
ValidDoubleValue(ListValue* tint_list, int index, double* out) {
On 2011/05/02 16:59:49, Mihai Parparita wrote:
> I think you can delete this now.

Done.

http://codereview.chromium.org/6901084/diff/5001/content/browser/host_zoom_ma...
File content/browser/host_zoom_map.cc (right):

http://codereview.chromium.org/6901084/diff/5001/content/browser/host_zoom_ma...
content/browser/host_zoom_map.cc:82: success =
host_zoom_dictionary->GetDoubleWithoutPathExpansion(
On 2011/05/02 16:17:04, John Abd-El-Malek wrote:
> why not only call GetDoubleWithoutPathExpansion?  for the old-profile code, it
> will do the casting internally.
> 
> we can also get rid of the code from line 75-82, since that was just needed
for
> converting old profiles.  this new way of storing zoom values has been like
this
> for several releases already, so I don't think we need to convert anymore.

Done. Removed the old code.

[jam, 2011-05-04 15:53:15]

content lgtm

[Mihai Parparita -not on Chrome, 2011-05-04 16:54:30]

LGTM to me too, but you may need more OWNERS approvals.