Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 690073002: Instrumenting AccountTracker::StartFetchingUserInfo to locate the source of jankiness (Closed)

Created:
6 years, 1 month ago by vadimt
Modified:
6 years, 1 month ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Instrumenting AccountTracker::StartFetchingUserInfo to locate the source of jankiness. Method AccountTracker::StartFetchingUserInfo is executed in browser's UI thread, and it causes jank. In Canary 40.0.2201.2 on Win, 19.9 jph is caused by AccountTracker::StartFetchingUserInfo, which average execution time in UI thread is 227 ms. On Mac, we have 17.7 jph and 71.1ms avg. I need to instrument the code inside it to find out which part causes jank. This is a mechanical change that adds instrumentation required to locate the source of jankiness (i.e. a long-running fragment of code executed as a part of the task that causes jank) in the code. See the bug for details on what kind of jank we are after. A number of similar CLs were landed, and none of them caused issues. They've helped to find and fix janky code. The code of the instrumentation is highly optimized and is not expected to affect performance. The code simply creates a diagnostic task which is identical to ones created by PostTask or IPC message handlers. The task gets created only in developer build and in Canary channel. BUG=422460 Committed: https://crrev.com/e924411b95fa49f84793ff8d33fc107f9a7a0a3b Cr-Commit-Position: refs/heads/master@{#302140}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -1 line) Patch
M google_apis/gaia/account_tracker.cc View 1 chunk +18 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
vadimt
rogerta@, please provide OWNER's approval
6 years, 1 month ago (2014-10-30 18:24:41 UTC) #2
zel
lgtm
6 years, 1 month ago (2014-10-30 18:45:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/690073002/1
6 years, 1 month ago (2014-10-30 18:59:22 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-30 19:57:16 UTC) #7
commit-bot: I haz the power
6 years, 1 month ago (2014-10-30 19:58:12 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e924411b95fa49f84793ff8d33fc107f9a7a0a3b
Cr-Commit-Position: refs/heads/master@{#302140}

Powered by Google App Engine
This is Rietveld 408576698