Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(579)

Unified Diff: google_apis/gaia/account_tracker.cc

Issue 690073002: Instrumenting AccountTracker::StartFetchingUserInfo to locate the source of jankiness (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: google_apis/gaia/account_tracker.cc
diff --git a/google_apis/gaia/account_tracker.cc b/google_apis/gaia/account_tracker.cc
index 1c29ee6e6445c5f2bb96b9e63e763b6b27d2ba19..794089a6f1f3a7a98fbeda6b9d35a2bd3957e182 100644
--- a/google_apis/gaia/account_tracker.cc
+++ b/google_apis/gaia/account_tracker.cc
@@ -236,16 +236,33 @@ void AccountTracker::StartFetchingUserInfo(const std::string account_key) {
FROM_HERE_WITH_EXPLICIT_FUNCTION(
"422460 AccountTracker::StartFetchingUserInfo"));
- if (ContainsKey(user_info_requests_, account_key))
+ if (ContainsKey(user_info_requests_, account_key)) {
+ // TODO(vadimt): Remove ScopedTracker below once crbug.com/422460 is fixed.
+ tracked_objects::ScopedTracker tracking_profile1(
+ FROM_HERE_WITH_EXPLICIT_FUNCTION(
+ "422460 AccountTracker::StartFetchingUserInfo 1"));
+
DeleteFetcher(user_info_requests_[account_key]);
+ }
DVLOG(1) << "StartFetching " << account_key;
+ // TODO(vadimt): Remove ScopedTracker below once crbug.com/422460 is fixed.
+ tracked_objects::ScopedTracker tracking_profile2(
+ FROM_HERE_WITH_EXPLICIT_FUNCTION(
+ "422460 AccountTracker::StartFetchingUserInfo 2"));
+
AccountIdFetcher* fetcher =
new AccountIdFetcher(identity_provider_->GetTokenService(),
request_context_getter_.get(),
this,
account_key);
user_info_requests_[account_key] = fetcher;
+
+ // TODO(vadimt): Remove ScopedTracker below once crbug.com/422460 is fixed.
+ tracked_objects::ScopedTracker tracking_profile3(
+ FROM_HERE_WITH_EXPLICIT_FUNCTION(
+ "422460 AccountTracker::StartFetchingUserInfo 3"));
+
fetcher->Start();
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698