Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Issue 689933004: Make OnDeviceEvent and OnDispatcherListChanged protected to allow overload. (Closed)

Created:
6 years, 1 month ago by Lidwine
Modified:
6 years, 1 month ago
Reviewers:
spang
CC:
chromium-reviews, kalyank, tdresser+watch_chromium.org, ozone-reviews_chromium.org
Base URL:
git://nuxepg2.fr.nds.com/CHROM/chromium-src.git@master
Project:
chromium
Visibility:
Public.

Description

Make OnDeviceEvent and OnDispatcherListChanged protected to allow overload. Only one event factory can exist. Make OnDeviceEvent/ OnDispatcherListChanged protected will allow to overload this implementation to add specific behaviour to the evdev input devices one. Add lgenevet@cisco.com in authors. Committed: https://crrev.com/59b25316ccb65952c04477ced23b9b40aac4a383 Cr-Commit-Position: refs/heads/master@{#302119}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -8 lines) Patch
M AUTHORS View 2 chunks +2 lines, -0 lines 0 comments Download
M ui/events/ozone/evdev/event_factory_evdev.h View 2 chunks +9 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Lidwine
On 2014/10/30 17:04:44, Lidwine wrote: > mailto:lgenevet@cisco.com changed reviewers: > + mailto:spang@chromium.org Resubmit with correct ...
6 years, 1 month ago (2014-10-30 17:07:17 UTC) #2
spang
lgtm
6 years, 1 month ago (2014-10-30 18:01:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/689933004/1
6 years, 1 month ago (2014-10-30 18:03:20 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-30 18:50:41 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-10-30 18:51:17 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/59b25316ccb65952c04477ced23b9b40aac4a383
Cr-Commit-Position: refs/heads/master@{#302119}

Powered by Google App Engine
This is Rietveld 408576698