Make OnDeviceEvent and OnDispatcherListChanged protected to allow overload.

Make OnDeviceEvent and OnDispatcherListChanged protected to allow overload.

Only one event factory can exist. Make OnDeviceEvent/ OnDispatcherListChanged
protected will allow to overload this implementation to add specific behaviour
to the evdev input devices one.
Add *@cisco.com in authors, as no cisco corporate changes were commited until now.

R=spang@chromium.org

[Lidwine Genevet, 2014-10-30 08:47:32]

On 2014/10/28 09:30:58, Lidwine Genevet wrote:
About Patch2
Someone from my team which is also in process of review was told to set his
individual cisco address and not the corporate one.
Cisco has sign a corporate CLA, with individual contributors.

[spang, 2014-10-30 14:24:32]

lgtm

[spang, 2014-10-30 14:24:45]

The CQ bit was checked by spang@chromium.org

[commit-bot: I haz the power, 2014-10-30 14:25:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/687523002/20001

[commit-bot: I haz the power, 2014-10-30 14:28:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-30 14:28:46]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[spang, 2014-10-30 14:31:02]

please reupload from your cisco email

[Lidwine, 2014-10-30 15:04:32]

Hi,

I uploaded again, removing the ".codereview_upload_cookies" and setting
lgenevet@cisco.com as email. I also have my cisco email set as git properties.
Is it necessary to change somewhere else? (My cisco email is linked in gmail
with my gmail email.)

Thx
Lidwine

-----Message d'origine-----
De : spang@chromium.org [mailto:spang@chromium.org] 
Envoyé : jeudi 30 octobre 2014 15:31
À : lidwine.genevet.cisco@gmail.com
Cc : chromium-reviews@chromium.org; kalyan.kondapally@intel.com;
tdresser+watch@chromium.org; ozone-reviews@chromium.org
Objet : Re: Make OnDeviceEvent and OnDispatcherListChanged protected to allow
overload. (issue 687523002 by lidwine.genevet.cisco@gmail.com)

please reupload from your cisco email

https://codereview.chromium.org/687523002/

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[spang, 2014-10-30 15:07:53]

I think you'll need to create a new issue in rietveld owned by the cisco
account.

[Lidwine, 2014-10-30 16:32:35]

Hi,
I created a new account directly with my cisco email. Is it ok to loose the
history of the other rietveld review? 
Shall I create a new branch with my commit to create a new review id?

Thx

Lidwine

-----Message d'origine-----
De : spang@chromium.org [mailto:spang@chromium.org] 
Envoyé : jeudi 30 octobre 2014 16:08
À : lidwine.genevet.cisco@gmail.com; Lidwine Genevet (lgenevet)
Cc : chromium-reviews@chromium.org; kalyan.kondapally@intel.com;
tdresser+watch@chromium.org; ozone-reviews@chromium.org
Objet : Re: Make OnDeviceEvent and OnDispatcherListChanged protected to allow
overload. (issue 687523002 by lidwine.genevet.cisco@gmail.com)

I think you'll need to create a new issue in rietveld owned by the cisco
account.

https://codereview.chromium.org/687523002/

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[spang, 2014-10-30 16:35:02]

Running "git cl issue 0" will let you upload a new issue with the same
branch.

On Thu, Oct 30, 2014 at 12:32 PM, Lidwine Genevet (lgenevet) <
lgenevet@cisco.com> wrote:

> Hi,
> I created a new account directly with my cisco email. Is it ok to loose
> the history of the other rietveld review?
> Shall I create a new branch with my commit to create a new review id?
>
> Thx
>
> Lidwine
>
> -----Message d'origine-----
> De : spang@chromium.org [mailto:spang@chromium.org]
> Envoyé : jeudi 30 octobre 2014 16:08
> À : lidwine.genevet.cisco@gmail.com; Lidwine Genevet (lgenevet)
> Cc : chromium-reviews@chromium.org; kalyan.kondapally@intel.com;
> tdresser+watch@chromium.org; ozone-reviews@chromium.org
> Objet : Re: Make OnDeviceEvent and OnDispatcherListChanged protected to
> allow overload. (issue 687523002 by lidwine.genevet.cisco@gmail.com)
>
> I think you'll need to create a new issue in rietveld owned by the cisco
> account.
>
> https://codereview.chromium.org/687523002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Lidwine Genevet, 2014-10-30 17:14:27]

On 2014/10/30 16:35:02, spang wrote:
> Running "git cl issue 0" will let you upload a new issue with the same
> branch.
> 
> On Thu, Oct 30, 2014 at 12:32 PM, Lidwine Genevet (lgenevet) <
> mailto:lgenevet@cisco.com> wrote:
> 
> > Hi,
> > I created a new account directly with my cisco email. Is it ok to loose
> > the history of the other rietveld review?
> > Shall I create a new branch with my commit to create a new review id?
> >
> > Thx
> >
> > Lidwine
> >
> > -----Message d'origine-----
> > De : mailto:spang@chromium.org [mailto:spang@chromium.org]
> > Envoyé : jeudi 30 octobre 2014 16:08
> > À : mailto:lidwine.genevet.cisco@gmail.com; Lidwine Genevet (lgenevet)
> > Cc : mailto:chromium-reviews@chromium.org;
mailto:kalyan.kondapally@intel.com;
> > mailto:tdresser+watch@chromium.org; mailto:ozone-reviews@chromium.org
> > Objet : Re: Make OnDeviceEvent and OnDispatcherListChanged protected to
> > allow overload. (issue 687523002 by mailto:lidwine.genevet.cisco@gmail.com)
> >
> > I think you'll need to create a new issue in rietveld owned by the cisco
> > account.
> >
> > https://codereview.chromium.org/687523002/
> >
> 
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.

Create new issue 689933004 with cisco account (695543002 review created again
with old account and deleted)