Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Unified Diff: sky/engine/core/rendering/shapes/ShapeOutsideInfo.cpp

Issue 689743002: First past at removing writing mode. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/core/rendering/RenderFlexibleBox.cpp ('k') | sky/engine/core/rendering/style/RenderStyle.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/core/rendering/shapes/ShapeOutsideInfo.cpp
diff --git a/sky/engine/core/rendering/shapes/ShapeOutsideInfo.cpp b/sky/engine/core/rendering/shapes/ShapeOutsideInfo.cpp
index 1a1b3840f3b35c81de0f32c61824e5e442c92203..2b5f579c3bd277c33a6e2d2430453ab18f3df353 100644
--- a/sky/engine/core/rendering/shapes/ShapeOutsideInfo.cpp
+++ b/sky/engine/core/rendering/shapes/ShapeOutsideInfo.cpp
@@ -159,27 +159,13 @@ const Shape& ShapeOutsideInfo::computedShape() const
inline LayoutUnit borderBeforeInWritingMode(const RenderBox& renderer, WritingMode writingMode)
{
- switch (writingMode) {
- case TopToBottomWritingMode: return renderer.borderTop();
- case BottomToTopWritingMode: return renderer.borderBottom();
- case LeftToRightWritingMode: return renderer.borderLeft();
- case RightToLeftWritingMode: return renderer.borderRight();
- }
-
- ASSERT_NOT_REACHED();
+ // FIXME(sky): Remove
return renderer.borderBefore();
}
inline LayoutUnit borderAndPaddingBeforeInWritingMode(const RenderBox& renderer, WritingMode writingMode)
{
- switch (writingMode) {
- case TopToBottomWritingMode: return renderer.borderTop() + renderer.paddingTop();
- case BottomToTopWritingMode: return renderer.borderBottom() + renderer.paddingBottom();
- case LeftToRightWritingMode: return renderer.borderLeft() + renderer.paddingLeft();
- case RightToLeftWritingMode: return renderer.borderRight() + renderer.paddingRight();
- }
-
- ASSERT_NOT_REACHED();
+ // FIXME(sky): Remove
return renderer.borderAndPaddingBefore();
}
« no previous file with comments | « sky/engine/core/rendering/RenderFlexibleBox.cpp ('k') | sky/engine/core/rendering/style/RenderStyle.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698