Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 689733003: Remove most of FloatingObject. (Closed)

Created:
6 years, 1 month ago by esprehn
Modified:
6 years, 1 month ago
Reviewers:
eseidel
CC:
mojo-reviews_chromium.org, ojan, abarth-chromium
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Remove most of FloatingObject. This leaves some uses of FloatingObject*, but it doesn't leave the impl of the class so it's all dead code passing around null pointers. I'll remove that in a future patch. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/b0032ab8530472c747fecf6302a4f944895cf44a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -1176 lines) Patch
M sky/engine/core/core.gni View 1 chunk +0 lines, -2 lines 0 comments Download
D sky/engine/core/rendering/FloatingObjects.h View 1 chunk +0 lines, -204 lines 0 comments Download
D sky/engine/core/rendering/FloatingObjects.cpp View 1 chunk +0 lines, -531 lines 0 comments Download
M sky/engine/core/rendering/RenderBlock.h View 2 chunks +0 lines, -4 lines 0 comments Download
M sky/engine/core/rendering/RenderBlock.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/rendering/RenderBlockFlow.h View 10 chunks +5 lines, -78 lines 0 comments Download
M sky/engine/core/rendering/RenderBlockFlow.cpp View 8 chunks +3 lines, -92 lines 0 comments Download
M sky/engine/core/rendering/RenderBlockLineLayout.cpp View 10 chunks +2 lines, -138 lines 0 comments Download
M sky/engine/core/rendering/RenderBoxModelObject.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/rendering/RenderInline.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/rendering/RenderView.h View 2 chunks +0 lines, -3 lines 0 comments Download
M sky/engine/core/rendering/RenderView.cpp View 1 chunk +0 lines, -7 lines 0 comments Download
M sky/engine/core/rendering/line/BreakingContextInlineHeaders.h View 7 chunks +0 lines, -29 lines 0 comments Download
M sky/engine/core/rendering/line/LineBreaker.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M sky/engine/core/rendering/line/LineWidth.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/rendering/line/LineWidth.cpp View 3 chunks +2 lines, -45 lines 0 comments Download
M sky/engine/core/rendering/shapes/ShapeOutsideInfo.cpp View 2 chunks +3 lines, -33 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
eseidel
lgtm
6 years, 1 month ago (2014-10-29 22:03:58 UTC) #2
esprehn
6 years, 1 month ago (2014-10-29 22:04:44 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
b0032ab8530472c747fecf6302a4f944895cf44a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698