Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 689693002: Add additional closeAllTabs(boolean uponExit) methods (Closed)

Created:
6 years, 1 month ago by Theresa
Modified:
6 years, 1 month ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add TabModel#closeAllTabs(boolean allowDelegation, boolean uponExit) and TabModelSelector#closeAllTabs(boolean uponExit) BUG=428084 Committed: https://crrev.com/a46e183d0f98713e8c4921dcff4b74301ddeaf5c Cr-Commit-Position: refs/heads/master@{#302293}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove TabModel#closeAllTabs(boolean allowDelegation) #

Messages

Total messages: 9 (2 generated)
Theresa
6 years, 1 month ago (2014-10-29 17:23:54 UTC) #2
David Trainor- moved to gerrit
lgtm https://codereview.chromium.org/689693002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModel.java File chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModel.java (right): https://codereview.chromium.org/689693002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModel.java#newcode99 chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModel.java:99: public void closeAllTabs(boolean allowDelegation, boolean uponExit); Hmm we ...
6 years, 1 month ago (2014-10-29 17:48:54 UTC) #3
Theresa
https://codereview.chromium.org/689693002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModel.java File chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModel.java (right): https://codereview.chromium.org/689693002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModel.java#newcode99 chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModel.java:99: public void closeAllTabs(boolean allowDelegation, boolean uponExit); On 2014/10/29 17:48:54, ...
6 years, 1 month ago (2014-10-29 18:00:17 UTC) #4
Theresa
6 years, 1 month ago (2014-10-29 18:12:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/689693002/20001
6 years, 1 month ago (2014-10-31 17:12:19 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-10-31 18:56:31 UTC) #8
commit-bot: I haz the power
6 years, 1 month ago (2014-10-31 18:57:49 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a46e183d0f98713e8c4921dcff4b74301ddeaf5c
Cr-Commit-Position: refs/heads/master@{#302293}

Powered by Google App Engine
This is Rietveld 408576698