Make login code not depend on Ash when use_athena=1

Make login code not depend on Ash when use_athena=1

BUG=426561
TEST=None

Committed: https://crrev.com/9eda0c6143f24b07ec13f27e22b586a39b7ea809
Cr-Commit-Position: refs/heads/master@{#302270}

[pkotwicz, 2014-10-30 01:50:37]

pkotwicz@chromium.org changed reviewers:
+ oshima@chromium.org

[pkotwicz, 2014-10-30 01:50:37]

Oshima, PTAL

I am using #if !defined(USE_ATHENA) in places where #if defined(USE_ASH) makes
more sense for now. It is trivial to do a find and replace though once athena no
longer uses ash.

[oshima, 2014-10-30 18:11:42]

https://codereview.chromium.org/689683004/diff/1/chrome/browser/chromeos/logi...
File chrome/browser/chromeos/login/helper.cc (right):

https://codereview.chromium.org/689683004/diff/1/chrome/browser/chromeos/logi...
chrome/browser/chromeos/login/helper.cc:29: gfx::Rect
bounds(ash::Shell::GetScreen()->GetPrimaryDisplay().bounds());
use gfx::Screen instead

https://codereview.chromium.org/689683004/diff/1/chrome/browser/chromeos/logi...
File chrome/browser/chromeos/login/lock/webui_screen_locker.cc (right):

https://codereview.chromium.org/689683004/diff/1/chrome/browser/chromeos/logi...
chrome/browser/chromeos/login/lock/webui_screen_locker.cc:88: bounds =
ash::Shell::GetScreen()->GetPrimaryDisplay().bounds();
ditto

[pkotwicz, 2014-10-30 21:47:33]

Patchset #2 (id:20001) has been deleted

[pkotwicz, 2014-10-30 21:49:19]

Oshima, can you please take another look?

[oshima, 2014-10-30 22:48:12]

lgtm with a nit

https://codereview.chromium.org/689683004/diff/40001/chrome/browser/chromeos/...
File chrome/browser/chromeos/login/ui/login_display_host_impl.cc (right):

https://codereview.chromium.org/689683004/diff/40001/chrome/browser/chromeos/...
chrome/browser/chromeos/login/ui/login_display_host_impl.cc:923: const
gfx::Size& size = ash::Shell::GetScreen()->GetPrimaryDisplay().size();
this one too?

[pkotwicz, 2014-10-31 14:43:20]

Patchset #3 (id:60001) has been deleted

[pkotwicz, 2014-10-31 14:46:51]

The CQ bit was checked by pkotwicz@chromium.org

[commit-bot: I haz the power, 2014-10-31 14:47:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/689683004/80001

[commit-bot: I haz the power, 2014-10-31 15:29:01]

Committed patchset #3 (id:80001)

[commit-bot: I haz the power, 2014-10-31 15:29:49]

Patchset 3 (id:??) landed as
https://crrev.com/9eda0c6143f24b07ec13f27e22b586a39b7ea809
Cr-Commit-Position: refs/heads/master@{#302270}