Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Unified Diff: chrome/browser/chromeos/login/lock/webui_screen_locker.h

Issue 689683004: Make login code not depend on Ash when use_athena=1 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@athena_do_not_use_ash44_ui
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/chromeos/login/helper.cc ('k') | chrome/browser/chromeos/login/lock/webui_screen_locker.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/login/lock/webui_screen_locker.h
diff --git a/chrome/browser/chromeos/login/lock/webui_screen_locker.h b/chrome/browser/chromeos/login/lock/webui_screen_locker.h
index 2fcad338b772f96442eb0cdb2cec873243fd0491..a98942675e8aa37d43b3190c4d32fef7164de67b 100644
--- a/chrome/browser/chromeos/login/lock/webui_screen_locker.h
+++ b/chrome/browser/chromeos/login/lock/webui_screen_locker.h
@@ -49,10 +49,14 @@ class WebUIScreenLocker : public WebUILoginView,
public LoginDisplay::Delegate,
public ScreenLockerDelegate,
public LockWindow::Observer,
+#if !defined(USE_ATHENA)
public ash::LockStateObserver,
+#endif
public views::WidgetObserver,
public PowerManagerClient::Observer,
+#if !defined(USE_ATHENA)
public ash::VirtualKeyboardStateObserver,
+#endif
public keyboard::KeyboardControllerObserver {
public:
explicit WebUIScreenLocker(ScreenLocker* screen_locker);
@@ -99,9 +103,11 @@ class WebUIScreenLocker : public WebUILoginView,
// LockWindow::Observer implementation.
virtual void OnLockWindowReady() override;
+#if !defined(USE_ATHENA)
// LockStateObserver override.
virtual void OnLockStateEvent(
ash::LockStateObserver::EventType event) override;
+#endif
// WidgetObserver override.
virtual void OnWidgetDestroying(views::Widget* widget) override;
@@ -114,8 +120,10 @@ class WebUIScreenLocker : public WebUILoginView,
// Overridden from content::WebContentsObserver:
virtual void RenderProcessGone(base::TerminationStatus status) override;
+#if !defined(USE_ATHENA)
// Overridden from ash::KeyboardStateObserver:
virtual void OnVirtualKeyboardStateChanged(bool activated) override;
+#endif
// Overridden from keyboard::KeyboardControllerObserver:
virtual void OnKeyboardBoundsChanging(const gfx::Rect& new_bounds) override;
« no previous file with comments | « chrome/browser/chromeos/login/helper.cc ('k') | chrome/browser/chromeos/login/lock/webui_screen_locker.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698