Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issue 689473005: aw: Do not merge kModeProcess into kModeDraw (Closed)

Created:
6 years, 1 month ago by boliu
Modified:
6 years, 1 month ago
Reviewers:
no sievers
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

aw: Do not merge kModeProcess into kModeDraw This no longer happens on Android L, and we have grown to rely on this behavior in some gpu scheduling code. Not bothering with refactoring code that work, but just match L behavior in the test runner. testNoUserScalableQuirk and testPageDown were flaky in hardware mode due to this bug, so make it run in hardware mode again. Fix style in these file too. BUG=428355 Committed: https://crrev.com/fbf6a309b2c25e63cf982d070c732f4ebbfd55ad Cr-Commit-Position: refs/heads/master@{#302891}

Patch Set 1 #

Patch Set 2 : also run testPageDown in hardware mode #

Patch Set 3 : style #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -104 lines) Patch
M android_webview/javatests/src/org/chromium/android_webview/test/AndroidScrollIntegrationTest.java View 1 2 7 chunks +43 lines, -46 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/AwLegacyQuirksTest.java View 11 chunks +53 lines, -56 lines 0 comments Download
M android_webview/test/shell/src/org/chromium/android_webview/test/AwTestContainerView.java View 1 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
boliu
And functor in instrumentation fix
6 years, 1 month ago (2014-11-04 23:04:55 UTC) #2
no sievers
lgtm
6 years, 1 month ago (2014-11-05 21:41:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/689473005/40001
6 years, 1 month ago (2014-11-05 21:47:21 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years, 1 month ago (2014-11-05 22:43:17 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-11-05 22:43:58 UTC) #7
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/fbf6a309b2c25e63cf982d070c732f4ebbfd55ad
Cr-Commit-Position: refs/heads/master@{#302891}

Powered by Google App Engine
This is Rietveld 408576698