Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 6893089: Modified Value::GetAsDouble so the function returns true when the object holds an Integer (Closed)

Created:
9 years, 8 months ago by Yusuke Sato
Modified:
9 years, 7 months ago
CC:
chromium-reviews, PaweĊ‚ Hajdan Jr., brettw-cc_chromium.org, Zachary Kuznia, bryeung
Visibility:
Public.

Description

Modified Value::GetAsDouble so the function returns true when the object holds an Integer. This should be useful when implementing an extension API in C++ since chrome.api.call(1.0); call in JS passes a Value of Integer to the C++ code while chrome.api.call(1.1); does a Value of Double. I'm working on this following Mihai's suggestion in http://codereview.chromium.org/6905053/. BUG=chromium-os:14421 TEST=ran try Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=83705

Patch Set 1 : review #

Total comments: 2

Patch Set 2 : review fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -3 lines) Patch
M base/values.cc View 1 1 chunk +3 lines, -1 line 0 comments Download
M base/values_unittest.cc View 1 2 chunks +7 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Yusuke Sato
Brett, Mihai, could you review this change?
9 years, 8 months ago (2011-04-28 08:25:06 UTC) #1
Mihai Parparita -not on Chrome
LGTM
9 years, 8 months ago (2011-04-28 18:29:57 UTC) #2
brettw
http://codereview.chromium.org/6893089/diff/1004/base/values.h File base/values.h (right): http://codereview.chromium.org/6893089/diff/1004/base/values.h#newcode98 base/values.h:98: virtual bool GetAsNumber(double* out_value) const; The documentation above this ...
9 years, 8 months ago (2011-04-28 20:12:01 UTC) #3
Yusuke Sato
Please take another look. http://codereview.chromium.org/6893089/diff/1004/base/values.h File base/values.h (right): http://codereview.chromium.org/6893089/diff/1004/base/values.h#newcode98 base/values.h:98: virtual bool GetAsNumber(double* out_value) const; ...
9 years, 7 months ago (2011-04-29 16:51:02 UTC) #4
Mihai Parparita -not on Chrome
LGTM
9 years, 7 months ago (2011-04-29 17:42:16 UTC) #5
brettw
9 years, 7 months ago (2011-04-29 21:07:14 UTC) #6
LGTM

Powered by Google App Engine
This is Rietveld 408576698