Modified Value::GetAsDouble so the function returns true when the object holds an Integer

Modified Value::GetAsDouble so the function returns true when the object holds an Integer.

This should be useful when implementing an extension API in C++ since chrome.api.call(1.0); call in JS passes a Value of Integer to the C++ code while chrome.api.call(1.1); does a Value of Double.

I'm working on this following Mihai's suggestion in http://codereview.chromium.org/6905053/.

BUG=chromium-os:14421
TEST=ran try

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=83705

[Yusuke Sato, 2011-04-28 08:25:06]

Brett, Mihai, could you review this change?

[Mihai Parparita -not on Chrome, 2011-04-28 18:29:57]

LGTM

[brettw, 2011-04-28 20:12:01]

http://codereview.chromium.org/6893089/diff/1004/base/values.h
File base/values.h (right):

http://codereview.chromium.org/6893089/diff/1004/base/values.h#newcode98
base/values.h:98: virtual bool GetAsNumber(double* out_value) const;
The documentation above this block says that these functions should convert if
possible. It seems like then maybe we should just be fixing GetAsDouble instead
of adding a new function.

[Yusuke Sato, 2011-04-29 16:51:02]

Please take another look.

http://codereview.chromium.org/6893089/diff/1004/base/values.h
File base/values.h (right):

http://codereview.chromium.org/6893089/diff/1004/base/values.h#newcode98
base/values.h:98: virtual bool GetAsNumber(double* out_value) const;
On 2011/04/28 20:12:01, brettw wrote:
> The documentation above this block says that these functions should convert if
> possible. It seems like then maybe we should just be fixing GetAsDouble
instead
> of adding a new function.

Done.

[Mihai Parparita -not on Chrome, 2011-04-29 17:42:16]

LGTM

[brettw, 2011-04-29 21:07:14]

LGTM