Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issue 689283003: Remove scroll corners and resizers. (Closed)

Created:
6 years, 1 month ago by ojan
Modified:
6 years, 1 month ago
Reviewers:
abarth-chromium
CC:
abarth-chromium, esprehn, mojo-reviews_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Remove scroll corners and resizers. We never paint scroll corners. The only thing we need them for is so that the vertical and horizontal scrollbars don't overlap each other. So, that's the only place left that still computes a scroll corner rect. We don't support resizers. Remove the code for them as well as the CSS resize property. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/46f30fed553e6e8b201d7021382712d3d134c32a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -737 lines) Patch
M sky/engine/core/css/CSSComputedStyleDeclaration.cpp View 2 chunks +0 lines, -3 lines 0 comments Download
M sky/engine/core/css/CSSPrimitiveValueMappings.h View 1 chunk +0 lines, -43 lines 0 comments Download
M sky/engine/core/css/CSSProperties.in View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/css/parser/BisonCSSParser-in.cpp View 2 chunks +0 lines, -3 lines 0 comments Download
M sky/engine/core/css/resolver/StyleBuilderCustom.cpp View 1 chunk +0 lines, -14 lines 0 comments Download
M sky/engine/core/frame/FrameView.h View 2 chunks +0 lines, -9 lines 0 comments Download
M sky/engine/core/frame/FrameView.cpp View 1 chunk +0 lines, -17 lines 0 comments Download
M sky/engine/core/frame/Settings.in View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/page/EventHandler.h View 4 chunks +0 lines, -8 lines 0 comments Download
M sky/engine/core/page/EventHandler.cpp View 11 chunks +8 lines, -78 lines 0 comments Download
M sky/engine/core/page/scrolling/ScrollingCoordinator.cpp View 1 chunk +0 lines, -14 lines 0 comments Download
M sky/engine/core/rendering/RenderBlock.h View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/rendering/RenderBlock.cpp View 2 chunks +0 lines, -17 lines 0 comments Download
M sky/engine/core/rendering/RenderBox.h View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/rendering/RenderBox.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M sky/engine/core/rendering/RenderLayer.cpp View 2 chunks +1 line, -6 lines 0 comments Download
M sky/engine/core/rendering/RenderLayerScrollableArea.h View 7 chunks +1 line, -39 lines 0 comments Download
M sky/engine/core/rendering/RenderLayerScrollableArea.cpp View 11 chunks +15 lines, -348 lines 0 comments Download
M sky/engine/core/rendering/compositing/CompositedLayerMapping.h View 4 chunks +1 line, -5 lines 0 comments Download
M sky/engine/core/rendering/compositing/CompositedLayerMapping.cpp View 10 chunks +5 lines, -33 lines 0 comments Download
M sky/engine/core/rendering/compositing/GraphicsLayerTreeBuilder.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M sky/engine/core/rendering/compositing/RenderLayerCompositor.h View 3 chunks +0 lines, -3 lines 0 comments Download
M sky/engine/core/rendering/compositing/RenderLayerCompositor.cpp View 4 chunks +0 lines, -22 lines 0 comments Download
M sky/engine/core/rendering/style/RenderStyle.h View 3 chunks +0 lines, -3 lines 0 comments Download
M sky/engine/core/rendering/style/RenderStyleConstants.h View 1 chunk +0 lines, -4 lines 0 comments Download
M sky/engine/core/rendering/style/StyleRareInheritedData.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/rendering/style/StyleRareInheritedData.cpp View 3 chunks +0 lines, -3 lines 0 comments Download
M sky/engine/platform/graphics/CompositingReasons.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/platform/graphics/CompositingReasons.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M sky/engine/platform/scroll/ScrollableArea.h View 3 chunks +0 lines, -6 lines 0 comments Download
M sky/engine/platform/scroll/ScrollableArea.cpp View 2 chunks +0 lines, -14 lines 0 comments Download
M sky/engine/platform/scroll/Scrollbar.h View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/platform/scroll/Scrollbar.cpp View 1 chunk +0 lines, -7 lines 0 comments Download
M sky/engine/public/platform/WebFallbackThemeEngine.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/public/platform/WebThemeEngine.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/public/web/WebSettings.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/testing/platform/webthemeengine_impl.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/web/WebSettingsImpl.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/web/WebSettingsImpl.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M sky/viewer/platform/webthemeengine_impl.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
abarth-chromium
lgtm
6 years, 1 month ago (2014-11-07 15:23:24 UTC) #2
abarth-chromium
amazing
6 years, 1 month ago (2014-11-07 15:23:32 UTC) #3
ojan
6 years, 1 month ago (2014-11-07 17:46:23 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
46f30fed553e6e8b201d7021382712d3d134c32a.

Powered by Google App Engine
This is Rietveld 408576698