Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Unified Diff: sky/engine/core/rendering/compositing/RenderLayerCompositor.cpp

Issue 689283003: Remove scroll corners and resizers. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sky/engine/core/rendering/compositing/RenderLayerCompositor.cpp
diff --git a/sky/engine/core/rendering/compositing/RenderLayerCompositor.cpp b/sky/engine/core/rendering/compositing/RenderLayerCompositor.cpp
index 384a31e756cabed06d6cdc1baafd2d8fe3705fed..bc6b0fd92cbbde6a00e2c6f1aad2780492164019 100644
--- a/sky/engine/core/rendering/compositing/RenderLayerCompositor.cpp
+++ b/sky/engine/core/rendering/compositing/RenderLayerCompositor.cpp
@@ -629,12 +629,6 @@ bool RenderLayerCompositor::requiresVerticalScrollbarLayer() const
return false;
}
-bool RenderLayerCompositor::requiresScrollCornerLayer() const
-{
- // FIXME(sky): Remove
- return false;
-}
-
void RenderLayerCompositor::updateOverflowControlsLayers()
{
GraphicsLayer* controlsParent = m_rootTransformLayer.get() ? m_rootTransformLayer.get() : m_overflowControlsHostLayer.get();
@@ -664,16 +658,6 @@ void RenderLayerCompositor::updateOverflowControlsLayers()
m_layerForVerticalScrollbar->removeFromParent();
m_layerForVerticalScrollbar = nullptr;
}
-
- if (requiresScrollCornerLayer()) {
- if (!m_layerForScrollCorner) {
- m_layerForScrollCorner = GraphicsLayer::create(graphicsLayerFactory(), this);
- controlsParent->addChild(m_layerForScrollCorner.get());
- }
- } else if (m_layerForScrollCorner) {
- m_layerForScrollCorner->removeFromParent();
- m_layerForScrollCorner = nullptr;
- }
}
void RenderLayerCompositor::ensureRootLayer()
@@ -743,10 +727,6 @@ void RenderLayerCompositor::destroyRootLayer()
m_layerForVerticalScrollbar = nullptr;
}
- if (m_layerForScrollCorner) {
- m_layerForScrollCorner = nullptr;
- }
-
if (m_overflowControlsHostLayer) {
m_overflowControlsHostLayer = nullptr;
m_containerLayer = nullptr;
@@ -849,8 +829,6 @@ String RenderLayerCompositor::debugName(const GraphicsLayer* graphicsLayer)
name = "Horizontal Scrollbar Layer";
} else if (graphicsLayer == m_layerForVerticalScrollbar.get()) {
name = "Vertical Scrollbar Layer";
- } else if (graphicsLayer == m_layerForScrollCorner.get()) {
- name = "Scroll Corner Layer";
} else if (graphicsLayer == m_containerLayer.get()) {
name = "LocalFrame Clipping Layer";
} else if (graphicsLayer == m_scrollLayer.get()) {
« no previous file with comments | « sky/engine/core/rendering/compositing/RenderLayerCompositor.h ('k') | sky/engine/core/rendering/style/RenderStyle.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698