Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(545)

Issue 689153007: Script to upload prebuilt network service (Closed)

Created:
6 years, 1 month ago by jamesr
Modified:
6 years, 1 month ago
Reviewers:
eseidel
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, yzshen1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Script to upload prebuilt network service Also patches in https://codereview.chromium.org/668993002 R=eseidel@chromium.org Committed: https://crrev.com/181466fe957d966cb13ab8c1ee3fb99742d05ee9 Cr-Commit-Position: refs/heads/master@{#302729}

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+174 lines, -23 lines) Patch
M mojo/services/network/udp_socket_impl.cc View 3 chunks +7 lines, -2 lines 0 comments Download
M mojo/services/network/udp_socket_unittest.cc View 5 chunks +94 lines, -21 lines 0 comments Download
A mojo/services/network/upload_network_service.py View 1 1 chunk +73 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
jamesr
6 years, 1 month ago (2014-11-04 23:58:44 UTC) #1
eseidel
This seems fine. Kinda hacky, but fine. python lgtm-ish. https://codereview.chromium.org/689153007/diff/1/mojo/services/network/upload_network_service.py File mojo/services/network/upload_network_service.py (right): https://codereview.chromium.org/689153007/diff/1/mojo/services/network/upload_network_service.py#newcode15 mojo/services/network/upload_network_service.py:15: ...
6 years, 1 month ago (2014-11-05 00:04:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/689153007/20001
6 years, 1 month ago (2014-11-05 00:32:26 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-11-05 01:18:53 UTC) #5
commit-bot: I haz the power
6 years, 1 month ago (2014-11-05 01:20:09 UTC) #6
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/181466fe957d966cb13ab8c1ee3fb99742d05ee9
Cr-Commit-Position: refs/heads/master@{#302729}

Powered by Google App Engine
This is Rietveld 408576698