Issue 668993002: Mojo UDP: add a client-side wrapper which handles the client<->server buffering for users.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 668993002: Mojo UDP: add a client-side wrapper which handles the client<->server buffering for users. (Closed)

Created:
6 years, 2 months ago by yzshen1

Modified:
6 years, 2 months ago

Reviewers:

Base URL:
https://github.com/domokit/mojo.git@master

Visibility:
Public.

Mojo UDP: add a client-side wrapper which handles the client<->server buffering for users. BUG=402671 TEST=newly added unittest TBR=brettw@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/c5edd3956df01d2467ec585f27f69009f240171e

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+459 lines, -46 lines)			Patch
M	mojo/mojo_services.gypi	View	1 chunk	+0 lines, -20 lines	0 comments	Download
M	mojo/services/network/BUILD.gn	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	mojo/services/network/udp_socket_impl.cc	View	3 chunks	+7 lines, -2 lines	0 comments	Download
M	mojo/services/network/udp_socket_unittest.cc	View	5 chunks	+94 lines, -21 lines	0 comments	Download
M	mojo/services/public/cpp/network/BUILD.gn	View	2 chunks	+3 lines, -1 line	0 comments	Download
A	mojo/services/public/cpp/network/udp_socket_wrapper.h	View	1 chunk	+145 lines, -0 lines	0 comments	Download
A	mojo/services/public/cpp/network/udp_socket_wrapper.cc	View	1 chunk	+207 lines, -0 lines	0 comments	Download
M	mojo/services/public/interfaces/network/udp_socket.mojom	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 2 (0 generated)

yzshen1

I am going to TBR brettw because he has reviewed this CL at: https://codereview.chromium.org/664243002

6 years, 2 months ago (2014-10-21 22:23:07 UTC) #1

yzshen1

6 years, 2 months ago (2014-10-21 22:25:23 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
c5edd3956df01d2467ec585f27f69009f240171e (presubmit successful).